From: Namhyung Kim <namhyung@gmail.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: [PATCH/RFC] md/raid10: optimize read_balance() for 'far copies' arrays
Date: Wed, 8 Jun 2011 16:00:45 +0900 [thread overview]
Message-ID: <1307516445-3208-1-git-send-email-namhyung@gmail.com> (raw)
If @conf->far_offset > 0, there is only 1 stripe so that we can treat
the array same as 'near' arrays. Furthermore we could calculate new
distance from the previous position even for the real 'far' array
cases if the position of given disk is already in the lowest stripe.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
drivers/md/raid10.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 6e846688962f..9ec4c5f8cd48 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -531,11 +531,19 @@ retry:
break;
/* for far > 1 always use the lowest address */
- if (conf->far_copies > 1)
- new_distance = r10_bio->devs[slot].addr;
- else
+ if (conf->far_copies > 1 && conf->far_offset == 0) {
+ if (conf->mirrors[disk].head_position < conf->stride &&
+ r10_bio->devs[slot].addr < conf->stride)
+ /* already in the lowest stripe */
+ new_distance = abs(r10_bio->devs[slot].addr -
+ conf->mirrors[disk].head_position);
+ else
+ new_distance = r10_bio->devs[slot].addr;
+ } else {
new_distance = abs(r10_bio->devs[slot].addr -
conf->mirrors[disk].head_position);
+ }
+
if (new_distance < best_dist) {
best_dist = new_distance;
best_slot = slot;
--
1.7.5.2
next reply other threads:[~2011-06-08 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 7:00 Namhyung Kim [this message]
2011-06-08 7:21 ` [PATCH/RFC] md/raid10: optimize read_balance() for 'far copies' arrays NeilBrown
2011-06-08 7:42 ` Namhyung Kim
2011-06-08 11:49 ` Keld Jørn Simonsen
2011-06-08 14:39 ` Namhyung Kim
2011-06-10 14:29 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307516445-3208-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).