From: Namhyung Kim <namhyung@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/5] misc cleanups for RAID5
Date: Thu, 23 Jun 2011 16:30:37 +0900 [thread overview]
Message-ID: <1308814237.1338.18.camel@leonhard> (raw)
In-Reply-To: <20110623105554.19c5fe09@notabene.brown>
2011-06-23 (목), 10:55 +1000, NeilBrown:
> Hi,
> thanks for these.
>
> I have applied the first and the last.
>
> The two "factor out" patches conflict with some much more substantial
> refactoring I have been doing in raid5.c. I have just pushed all of that
> into my for-next branch:
>
> git://neil.brown.name/md for-next
>
> so you can use that as a basis for any further review.
Thanks. I'll have a look at that.
>
> The r5_for_each_bio() patch I'm not 100% sure I'm happy with, and in any
> case it would have conflicted with my other changes too.
> I'm not fond of macros that hide details that could be important. A
> "for_each" macro that purely and simply walks through a list is fine. A
> "for_each" macro that does anything more complicated I start to have doubts
> about...
> However if you really do like it and want to rebase it on the for-next
> branch I'll have another look and think harder about it. Maybe I'll end up
> liking it after all, but no promises.
I don't have any strong opinion on it. It was just a suggestion that I
think it helps the code cleaner but ...
Anyway, thanks for your comment.
--
Regards,
Namhyung Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2011-06-23 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 4:50 [PATCH 0/5] misc cleanups for RAID5 Namhyung Kim
2011-06-22 4:50 ` [PATCH 1/5] md/raid5: use kmem_cache_zalloc() Namhyung Kim
2011-06-22 4:50 ` [PATCH 2/5] md/raid5: factor out dev_need_read() Namhyung Kim
2011-06-22 4:50 ` [PATCH 3/5] md/raid5: factor out dev_need_for_write() Namhyung Kim
2011-06-22 4:50 ` [PATCH 4/5] md/raid5: use r5_for_each_bio() Namhyung Kim
2011-06-22 4:50 ` [PATCH 5/5] md/raid5: get rid of duplicated call to bio_data_dir() Namhyung Kim
2011-06-23 0:55 ` [PATCH 0/5] misc cleanups for RAID5 NeilBrown
2011-06-23 7:30 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308814237.1338.18.camel@leonhard \
--to=namhyung@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).