* [PATCH] md: don't delay reboot by 1 second if no MD devices exist
@ 2011-09-23 9:40 Daniel P. Berrange
2011-09-23 9:55 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrange @ 2011-09-23 9:40 UTC (permalink / raw)
To: Neil Brown; +Cc: linux-raid, linux-kernel, Daniel P. Berrange
From: "Daniel P. Berrange" <berrange@redhat.com>
The md_notify_reboot() method includes a call to mdelay(1000),
to deal with "exotic SCSI devices" which are too volatile on
reboot. The delay is unconditional. Even if the machine does
not have any block devices, let alone MD devices, the kernel
shutdown sequence is slowed down.
1 second does not matter much with physical hardware, but with
certain virtualization use cases any wasted time in the bootup
& shutdown sequence counts for alot.
* drivers/md/md.c: md_notify_reboot() - only impose a delay if
there was at least one MD device to be stopped during reboot
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
drivers/md/md.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 5404b22..ef7ad8d 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8059,12 +8059,13 @@ static int md_notify_reboot(struct notifier_block *this,
{
struct list_head *tmp;
mddev_t *mddev;
+ int need_delay = 0;
if ((code == SYS_DOWN) || (code == SYS_HALT) || (code == SYS_POWER_OFF)) {
printk(KERN_INFO "md: stopping all md devices.\n");
- for_each_mddev(mddev, tmp)
+ for_each_mddev(mddev, tmp) {
if (mddev_trylock(mddev)) {
/* Force a switch to readonly even array
* appears to still be in use. Hence
@@ -8073,13 +8074,16 @@ static int md_notify_reboot(struct notifier_block *this,
md_set_readonly(mddev, 100);
mddev_unlock(mddev);
}
+ need_delay = 1;
+ }
/*
* certain more exotic SCSI devices are known to be
* volatile wrt too early system reboots. While the
* right place to handle this issue is the given
* driver, we do want to have a safe RAID driver ...
*/
- mdelay(1000*1);
+ if (need_delay)
+ mdelay(1000*1);
}
return NOTIFY_DONE;
}
--
1.7.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md: don't delay reboot by 1 second if no MD devices exist
2011-09-23 9:40 [PATCH] md: don't delay reboot by 1 second if no MD devices exist Daniel P. Berrange
@ 2011-09-23 9:55 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-09-23 9:55 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: linux-raid, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2218 bytes --]
On Fri, 23 Sep 2011 10:40:45 +0100 "Daniel P. Berrange" <berrange@redhat.com>
wrote:
> From: "Daniel P. Berrange" <berrange@redhat.com>
>
> The md_notify_reboot() method includes a call to mdelay(1000),
> to deal with "exotic SCSI devices" which are too volatile on
> reboot. The delay is unconditional. Even if the machine does
> not have any block devices, let alone MD devices, the kernel
> shutdown sequence is slowed down.
>
> 1 second does not matter much with physical hardware, but with
> certain virtualization use cases any wasted time in the bootup
> & shutdown sequence counts for alot.
>
> * drivers/md/md.c: md_notify_reboot() - only impose a delay if
> there was at least one MD device to be stopped during reboot
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
queued for next merge window .... or maybe even next -rc if I'm feeling
brave.
Thanks,
NeilBrown
> ---
> drivers/md/md.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 5404b22..ef7ad8d 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -8059,12 +8059,13 @@ static int md_notify_reboot(struct notifier_block *this,
> {
> struct list_head *tmp;
> mddev_t *mddev;
> + int need_delay = 0;
>
> if ((code == SYS_DOWN) || (code == SYS_HALT) || (code == SYS_POWER_OFF)) {
>
> printk(KERN_INFO "md: stopping all md devices.\n");
>
> - for_each_mddev(mddev, tmp)
> + for_each_mddev(mddev, tmp) {
> if (mddev_trylock(mddev)) {
> /* Force a switch to readonly even array
> * appears to still be in use. Hence
> @@ -8073,13 +8074,16 @@ static int md_notify_reboot(struct notifier_block *this,
> md_set_readonly(mddev, 100);
> mddev_unlock(mddev);
> }
> + need_delay = 1;
> + }
> /*
> * certain more exotic SCSI devices are known to be
> * volatile wrt too early system reboots. While the
> * right place to handle this issue is the given
> * driver, we do want to have a safe RAID driver ...
> */
> - mdelay(1000*1);
> + if (need_delay)
> + mdelay(1000*1);
> }
> return NOTIFY_DONE;
> }
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 9:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 9:40 [PATCH] md: don't delay reboot by 1 second if no MD devices exist Daniel P. Berrange
2011-09-23 9:55 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).