From: Jes.Sorensen@redhat.com
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, dledford@redhat.com
Subject: [PATCH 1/2] Avoid use after free
Date: Fri, 28 Oct 2011 21:50:50 +0200 [thread overview]
Message-ID: <1319831451-26704-2-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1319831451-26704-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
If picking just one spare disk from the container, jump out of the
loop once freeing the list. Otherwise we end up accessing the list
that we just freed.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
util.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/util.c b/util.c
index 2cf617d..1bbd87f 100644
--- a/util.c
+++ b/util.c
@@ -1766,6 +1766,7 @@ struct mdinfo *container_choose_spares(struct supertype *st,
if (get_one) {
sysfs_free(*dp);
d->next = NULL;
+ goto out;
}
} else {
*dp = d->next;
@@ -1773,5 +1774,6 @@ struct mdinfo *container_choose_spares(struct supertype *st,
sysfs_free(d);
}
}
+out:
return disks;
}
--
1.7.6.4
next prev parent reply other threads:[~2011-10-28 19:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 19:50 [PATCH 0/2] Misc fixes Jes.Sorensen
2011-10-28 19:50 ` Jes.Sorensen [this message]
2011-10-30 23:43 ` [PATCH 1/2] Avoid use after free NeilBrown
2011-10-31 7:41 ` Jes Sorensen
2011-10-28 19:50 ` [PATCH 2/2] Avoid stack overflow if GPT partition entries on disk are > 128 bytes Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319831451-26704-2-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).