linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 11/11] mdmon(): Error out if failing to connect to victim monitor
Date: Mon, 31 Oct 2011 15:02:39 +0100	[thread overview]
Message-ID: <1320069759-13361-12-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1320069759-13361-1-git-send-email-Jes.Sorensen@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 mdmon.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/mdmon.c b/mdmon.c
index ee68e3c..bdcda0e 100644
--- a/mdmon.c
+++ b/mdmon.c
@@ -457,8 +457,14 @@ static int mdmon(char *devname, int devnum, int must_fork, int takeover)
 	sigaction(SIGPIPE, &act, NULL);
 
 	victim = mdmon_pid(container->devnum);
-	if (victim >= 0)
+	if (victim >= 0) {
 		victim_sock = connect_monitor(container->devname);
+		if (victim_sock < 0) {
+			fprintf(stderr, "mdmon: %s unable to connect monitor\n",
+				container->devname);
+			exit(3);
+		}
+	}
 
 	ignore = chdir("/");
 	if (!takeover && victim > 0 && victim_sock >= 0) {
-- 
1.7.6.4


  parent reply	other threads:[~2011-10-31 14:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 14:02 [PATCH 00/11] Memory/resource leaks and unchecked return fixes Jes.Sorensen
2011-10-31 14:02 ` [PATCH 01/11] Fix memory leaks in reshape_array() Jes.Sorensen
2011-10-31 14:02 ` [PATCH 02/11] Fix memory leak Jes.Sorensen
2011-10-31 14:02 ` [PATCH 03/11] " Jes.Sorensen
2011-10-31 14:02 ` [PATCH 04/11] Fix memory leak of 'st3' in array_try_spare() Jes.Sorensen
2011-10-31 14:02 ` [PATCH 05/11] partition_try_spare() use closedir() to release DIR * returned by opendir() Jes.Sorensen
2011-10-31 14:02 ` [PATCH 06/11] Fix memory leak Jes.Sorensen
2011-10-31 14:02 ` [PATCH 07/11] Add missing return in case of trying to grow sub-array Jes.Sorensen
2011-10-31 14:02 ` [PATCH 08/11] Avoid memory leak Jes.Sorensen
2011-10-31 14:02 ` [PATCH 09/11] policy_add(): Add missing va_end() Jes.Sorensen
2011-10-31 14:02 ` [PATCH 10/11] Write_rules(): Avoid stack corruption if using extremely long udev pathname Jes.Sorensen
2011-10-31 14:02 ` Jes.Sorensen [this message]
2011-11-01  3:57 ` [PATCH 00/11] Memory/resource leaks and unchecked return fixes NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320069759-13361-12-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).