Re: [md PATCH 1/1] add display of hours remaining to finish resync

[Paul Menzel <pm.debian@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1984 bytes --]

Dear Krzysztof,


Am Dienstag, den 01.11.2011, 17:53 -0400 schrieb Krzysztof Adamski:
> This is my first patch, so please be gentle.

thank you for your patch. The line above does not belong to the commit
message. You can put that below the commit message after »---« or on top
and separate the patch using »--- 8< ----«. (See `git help am` for more
information.

> This patch adds the display of the number of hours till the completion
> of resync of an array in the /proc/mdstat display.
> 
> Example: [>....................]  resync =  3.3% (98633240/2928311808)
> finish=1026.1min (17h) speed=45957K/sec
> 
> Signed-off-by: Krzysztof Adamski <k@adamski.org>
> 
> # diff -Naru drivers/md/md.c-orig  drivers/md/md.c

It would be easier if you used `git commit` and for example

    git format-patch -1 -s

and then sent it using `git send-email` or your MUA (see below).

> --- drivers/md/md.c-orig        2011-10-25 01:11:12.000000000 -0400
> +++ drivers/md/md.c     2011-11-01 17:37:35.000000000 -0400
> @@ -6351,8 +6351,8 @@
>         rt *= dt;
>         rt >>= 5;
>  
> -       seq_printf(seq, " finish=%lu.%lumin", (unsigned long)rt / 60,
> -                  ((unsigned long)rt % 60)/6);
> +       seq_printf(seq, " finish=%lu.%lumin (%luh)", (unsigned long)rt /
> 60,
> +                  ((unsigned long)rt % 60)/6, (unsigned long)rt / 60 /
> 60);

Unfortunately your mailer mangled the patch. You should choose pre
formatted, so automatic line breaks do not happen, which prevent the
application of the patch.

>  
>         seq_printf(seq, " speed=%ldK/sec", db/2/dt);
>  }

Please resend this patch as v2.

    git format-patch --subject-prefix="PATCH v2"

I am not sure if it should be a reply to the same thread or a new
message.

You can add the following line to the the commit message.

Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>

(Different address on purpose.)


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]