Re: [PATCH] md: Add ability for disable bad block management

[Paul Menzel <pm.debian@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

Dear Adam,


Am Donnerstag, den 24.11.2011, 13:19 +0100 schrieb Adam Kwolek:
> When external metadata doesn't support BBM, mdadm cannot answer correctly
> for BBM requests. It causes reshape process being stopped.
> 
> Add ability for external metadata /mdadm/ to disable BBM via sysfs.
> md will ignore bad blocks as it is for metadata v0.90.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
> 
>  drivers/md/md.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 266e82e..6591108 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -2935,7 +2935,16 @@ static ssize_t bb_show(struct md_rdev *rdev, char *page)
>  }
>  static ssize_t bb_store(struct md_rdev *rdev, const char *page, size_t len)
>  {
> -	int rv = badblocks_store(&rdev->badblocks, page, len, 0);
> +	int rv;
> +
> +	/* disable bad blocks managment

manag*e*ment

> +	 */
> +	if (strstr(page, "disable") == page) {
> +		bb->shift = -1;
> +		return len;
> +	}
> +
> +	rv = badblocks_store(&rdev->badblocks, page, len, 0);
>  	/* Maybe that ack was all we needed */
>  	if (test_and_clear_bit(BlockedBadBlocks, &rdev->flags))
>  		wake_up(&rdev->blocked_wait);

Also this seems to collide with PATCH 11/11, does not it?


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]