linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrei Warkentin <andrey.warkentin@gmail.com>
To: linux-raid@vger.kernel.org
Cc: Andrei Warkentin <andrey.warkentin@gmail.com>
Subject: [PATCH] MD: Bitmap version cleanup.
Date: Sun, 15 Jan 2012 03:09:46 -0500	[thread overview]
Message-ID: <1326614986-30166-1-git-send-email-andrey.warkentin@gmail.com> (raw)

bitmap_new_disk_sb() would still create V3 bitmap superblock
with host-endian layout.

Perhaps I'm confused, but shouldn't bitmap_new_disk_sb() be
creating a V4 bitmap superblock instead, that is portable,
as per comment in bitmap.h? BITMAP_MINOR was also unused.

Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
---
 drivers/md/bitmap.c |    3 ---
 drivers/md/bitmap.h |    2 --
 2 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 045e086..e786da6 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -568,9 +568,6 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap)
 	bitmap->events_cleared = bitmap->mddev->events;
 	sb->events_cleared = cpu_to_le64(bitmap->mddev->events);
 
-	bitmap->flags |= BITMAP_HOSTENDIAN;
-	sb->version = cpu_to_le32(BITMAP_MAJOR_HOSTENDIAN);
-
 	kunmap_atomic(sb);
 
 	return 0;
diff --git a/drivers/md/bitmap.h b/drivers/md/bitmap.h
index a15436d..af588ac 100644
--- a/drivers/md/bitmap.h
+++ b/drivers/md/bitmap.h
@@ -13,8 +13,6 @@
 #define BITMAP_MAJOR_HI 4
 #define	BITMAP_MAJOR_HOSTENDIAN 3
 
-#define BITMAP_MINOR 39
-
 /*
  * in-memory bitmap:
  *
-- 
1.7.8.3


             reply	other threads:[~2012-01-15  8:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15  8:09 Andrei Warkentin [this message]
2012-04-10  6:14 ` [PATCH] MD: Bitmap version cleanup NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326614986-30166-1-git-send-email-andrey.warkentin@gmail.com \
    --to=andrey.warkentin@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).