linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 1/1] Make error message on failure to --re-add more explicit
Date: Wed, 22 Feb 2012 18:00:00 +0100	[thread overview]
Message-ID: <1329930000-20679-2-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1329930000-20679-1-git-send-email-Jes.Sorensen@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 Manage.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/Manage.c b/Manage.c
index d9775de..0f9135b 100644
--- a/Manage.c
+++ b/Manage.c
@@ -861,8 +861,12 @@ int Manage_subdevs(char *devname, int fd,
 						dv->devname, devname);
 					fprintf(stderr, Name ": not performing --add as that would convert %s in to a spare.\n",
 						dv->devname);
-					fprintf(stderr, Name ": To make this a spare, use \"mdadm --zero-superblock %s\" first.\n",	
+					fprintf(stderr, Name ": To make this a spare, use \"mdadm --zero-superblock %s\" first.\n",
 						dv->devname);
+					fprintf(stderr, Name ": Note mdadm used to accept re-adding a drive to a raid1 array,\n");
+					fprintf(stderr, Name ": which was a bug. For raid1 arrays it is not possible to\n");
+					fprintf(stderr, Name ": determine which disk is authoritative, and the admin must\n");
+					fprintf(stderr, Name ": decide whether the drive should be converted into a spare.\n");
 					if (tfd >= 0)
 						close(tfd);
 					return 1;
-- 
1.7.4.4


  reply	other threads:[~2012-02-22 17:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 16:59 [PATCH 0/1] Make failure message on re-add more explcit Jes.Sorensen
2012-02-22 17:00 ` Jes.Sorensen [this message]
2012-02-22 22:04 ` NeilBrown
2012-02-22 23:16   ` Jes Sorensen
2012-02-23  1:57     ` John Robinson
2012-02-23  8:34       ` Jes Sorensen
2012-02-23  8:47         ` J. Ali Harlow
2012-02-27  0:01           ` NeilBrown
2012-04-05 18:59   ` Doug Ledford
2012-04-09 23:41     ` NeilBrown
2012-04-10 23:44       ` Doug Ledford
2012-04-18  4:25         ` NeilBrown
2012-04-23 19:36           ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329930000-20679-2-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).