Re: [MDADM PATCH 1/1] Array size is wrong when run mdadm -E

[Xiao Ni <xni@redhat.com>]

----- Original Message -----
> From: "Guoqing Jiang" <gqjiang@suse.com>
> To: "Xiao Ni" <xni@redhat.com>, linux-raid@vger.kernel.org
> Cc: ncroxon@redhat.com, "jes sorensen" <jes.sorensen@gmail.com>
> Sent: Tuesday, July 4, 2017 5:03:30 PM
> Subject: Re: [MDADM PATCH 1/1] Array size is wrong when run mdadm -E
> 
> 
> 
> On 07/04/2017 02:50 PM, Xiao Ni wrote:
> > The size of array shows wrongly. It shifs wrong number.
> >
> > Signed-off-by: Xiao Ni <xni@redhat.com>
> > ---
> >   super1.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/super1.c b/super1.c
> > index 86ec850..f3b864d 100644
> > --- a/super1.c
> > +++ b/super1.c
> > @@ -366,7 +366,7 @@ static void examine_super1(struct supertype *st, char
> > *homehost)
> >   		}
> >   		if (ddsks) {
> >   			long long asize = __le64_to_cpu(sb->size);
> > -			asize = (asize << 9) * ddsks / ddsks_denom;
> > +			asize = (asize << 10) * ddsks / ddsks_denom;
> >   			printf("     Array Size : %llu%s\n",
> >   			       asize >> 10,  human_size(asize));
> >   		}
> 
> IIRC, sb->size represents the num of sectors, so the shift should be 9.

Yes, it should be 9. It should pass bytes to human_size. Thanks for this.
It was introduced in d4633e06dfc01723911627fcb104af2ffb6f6a95. So there is
the same problem in super0. Is it ok:

diff --git a/super0.c b/super0.c
index 756cab5..4b4680c 100644
--- a/super0.c
+++ b/super0.c
@@ -131,9 +131,9 @@ static void examine_super0(struct supertype *st, char *homehost)
                }
                if (ddsks) {
                        long long asize = sb->size;
-                       asize = (asize << 10) * ddsks / ddsks_denom;
+                       asize = (asize << 9) * ddsks / ddsks_denom;
                        printf("     Array Size : %llu%s\n",
-                              asize >> 10,  human_size(asize));
+                              asize >> 9,  human_size(asize));
                }
        }
        printf("   Raid Devices : %d\n", sb->raid_disks);
diff --git a/super1.c b/super1.c
index 86ec850..2bb1454 100644
--- a/super1.c
+++ b/super1.c
@@ -368,7 +368,7 @@ static void examine_super1(struct supertype *st, char *homehost)
                        long long asize = __le64_to_cpu(sb->size);
                        asize = (asize << 9) * ddsks / ddsks_denom;
                        printf("     Array Size : %llu%s\n",
-                              asize >> 10,  human_size(asize));
+                              asize >> 9,  human_size(asize));
                }
                if (sb->size != sb->data_size)
                        printf("  Used Dev Size : %llu%s\n",

Regards
Xiao
> 
> Thanks,
> Guoqing
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>