linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 00/11] Various cleanups and minor fixes
Date: Tue, 20 Mar 2012 17:54:05 +0100	[thread overview]
Message-ID: <1332262456-5109-1-git-send-email-Jes.Sorensen@redhat.com> (raw)

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Hi,

This patch set implements a number of smaller cleanups, as well as
fixing a couple of cases where we don't zero out the full buffer we
just obtained via malloc.

The most controversial is probably patch 06 which caches the device
block size for aligned read/writes in super1.c to avoid calling the
ioctl() on each write.

I also introduced some generalized ROUND_UP macros to avoid the manual
pointer and size manipulation in various places.

The ddf code I am unable to test as I don't have any raids with ddf
layout, but it does compile.

Cheers,
Jes


Jes Sorensen (11):
  super1.c don't keep recalculating bitmap pointer
  Define and use SUPER1_SIZE for allocations
  init_super1() memset full buffer allocated for superblock
  match_metadata_desc1(): Use calloc instead of malloc+memset
  Use 4K buffer alignment for superblock allocations
  Use struct align_fd to cache fd's block size for aligned reads/writes
  match_metadata_desc0(): Use calloc instead of malloc+memset
  Generalize ROUND_UP() macro and introduce matching ROUND_UP_PTR()
  super1.c: use ROUND_UP/ROUND_UP_PTR
  super-intel.c: Use ROUND_UP() instead of manually coding it
  __write_init_super_ddf(): Use posix_memalign() instead of static
    aligned buffer

 mdadm.h       |    8 ++--
 super-ddf.c   |   19 ++++++----
 super-intel.c |    2 +-
 super0.c      |    6 ++--
 super1.c      |  111 +++++++++++++++++++++++++++++++++++----------------------
 5 files changed, 87 insertions(+), 59 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-03-20 16:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-20 16:54 Jes.Sorensen [this message]
2012-03-20 16:54 ` [PATCH 01/11] super1.c don't keep recalculating bitmap pointer Jes.Sorensen
2012-03-20 16:54 ` [PATCH 02/11] Define and use SUPER1_SIZE for allocations Jes.Sorensen
2012-03-20 16:54 ` [PATCH 03/11] init_super1() memset full buffer allocated for superblock Jes.Sorensen
2012-03-20 16:54 ` [PATCH 04/11] match_metadata_desc1(): Use calloc instead of malloc+memset Jes.Sorensen
2012-03-20 16:54 ` [PATCH 05/11] Use 4K buffer alignment for superblock allocations Jes.Sorensen
2012-03-20 16:54 ` [PATCH 06/11] Use struct align_fd to cache fd's block size for aligned reads/writes Jes.Sorensen
2012-03-20 16:54 ` [PATCH 07/11] match_metadata_desc0(): Use calloc instead of malloc+memset Jes.Sorensen
2012-03-20 16:54 ` [PATCH 08/11] Generalize ROUND_UP() macro and introduce matching ROUND_UP_PTR() Jes.Sorensen
2012-03-20 16:54 ` [PATCH 09/11] super1.c: use ROUND_UP/ROUND_UP_PTR Jes.Sorensen
2012-03-20 16:54 ` [PATCH 10/11] super-intel.c: Use ROUND_UP() instead of manually coding it Jes.Sorensen
2012-03-20 16:54 ` [PATCH 11/11] __write_init_super_ddf(): Use posix_memalign() instead of static aligned buffer Jes.Sorensen
2012-03-20 21:11 ` [PATCH 00/11] Various cleanups and minor fixes NeilBrown
2012-03-21  7:58   ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332262456-5109-1-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).