From: Jonathan Brassow <jbrassow@redhat.com>
To: dm-devel@redhat.com, linux-raid@vger.kernel.org
Cc: agk@redhat.com, neilb@suse.de
Subject: [PATCH 0 of 2] dm-raid: Bug fixes
Date: Mon, 16 Apr 2012 18:45:17 -0500 [thread overview]
Message-ID: <1334619917.16017.25.camel@f14.redhat.com> (raw)
Neil,
I have 3 bugs that I've been working on. Two I have fixed and one I
have not, but have a question.
The first patch (dm-raid-set-recovery-flags-on-resume) addresses the
fact that some recovery flags are altered during suspend, but not
corrected upon resume. I'm wondering if you think these flags would be
better pushed into 'mddev_resume' rather that being altered in
dm-raid.c?
The second patch (dm-raid-record-and-handle-missing-devices) adds code
to address the case where the user specifies particular array positions
as missing. I don't have any significant questions about this patch.
The 3rd issue I am seeing concerns how 'suspend' happens. Suspend
should flush all outstanding I/O and quiesce. When I look at the code,
I feel it should be doing this. ('md_stop_writes' is called and
followed-up by a call to 'mddev_suspend', which quiesces the
personality.) However, if I create a RAID1 device, suspend it, and then
detach one of the legs, it does not show the changes written immediately
before the suspend. If I issue a 'sync', then the changes do show-up.
I confused as to why the suspend process doesn't seem to be pushing out
the writes that have been issued. Any ideas?
Thanks, (the first two patches follow)
brassow
next reply other threads:[~2012-04-16 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 23:45 Jonathan Brassow [this message]
2012-04-17 4:26 ` [PATCH 0 of 2] dm-raid: Bug fixes NeilBrown
2012-04-18 1:09 ` Brassow Jonathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334619917.16017.25.camel@f14.redhat.com \
--to=jbrassow@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).