* [PATCH] MD RAID10: Fix compiler warning.
@ 2012-06-26 8:40 Jonathan Brassow
2012-07-04 1:12 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Brassow @ 2012-06-26 8:40 UTC (permalink / raw)
To: neilb; +Cc: linux-raid
MD RAID10: Fix compiler warning.
Initialize variable to prevent compiler warning.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-upstream/drivers/md/raid10.c
===================================================================
--- linux-upstream.orig/drivers/md/raid10.c
+++ linux-upstream/drivers/md/raid10.c
@@ -717,7 +717,7 @@ static struct md_rdev *read_balance(stru
int sectors = r10_bio->sectors;
int best_good_sectors;
sector_t new_distance, best_dist;
- struct md_rdev *rdev, *best_rdev;
+ struct md_rdev *best_rdev, *rdev = NULL;
int do_balance;
int best_slot;
struct geom *geo = &conf->geo;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MD RAID10: Fix compiler warning.
2012-06-26 8:40 [PATCH] MD RAID10: Fix compiler warning Jonathan Brassow
@ 2012-07-04 1:12 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-07-04 1:12 UTC (permalink / raw)
To: Jonathan Brassow; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Tue, 26 Jun 2012 03:40:13 -0500 Jonathan Brassow <jbrassow@redhat.com>
wrote:
> MD RAID10: Fix compiler warning.
>
> Initialize variable to prevent compiler warning.
>
> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
> Index: linux-upstream/drivers/md/raid10.c
> ===================================================================
> --- linux-upstream.orig/drivers/md/raid10.c
> +++ linux-upstream/drivers/md/raid10.c
> @@ -717,7 +717,7 @@ static struct md_rdev *read_balance(stru
> int sectors = r10_bio->sectors;
> int best_good_sectors;
> sector_t new_distance, best_dist;
> - struct md_rdev *rdev, *best_rdev;
> + struct md_rdev *best_rdev, *rdev = NULL;
> int do_balance;
> int best_slot;
> struct geom *geo = &conf->geo;
>
Applied, thanks.
I'm fairly sure it is a bogus warning, but initializing to NULL won't hurt.
Thanks,
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-04 1:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-26 8:40 [PATCH] MD RAID10: Fix compiler warning Jonathan Brassow
2012-07-04 1:12 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).