linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix tests sh too many arguments warnings
@ 2012-10-10 11:38 Gilles Espinasse
  2012-10-10 23:39 ` NeilBrown
  0 siblings, 1 reply; 2+ messages in thread
From: Gilles Espinasse @ 2012-10-10 11:38 UTC (permalink / raw)
  To: linux-raid, neilb; +Cc: Gilles Espinasse

Signed-off-by: Gilles Espinasse <g.esp@free.fr>

Add quotes on if [ $sum != $sum1 ]
Fix 2 typo /sh1sum/sha1sum/ /matc /match /
---
 tests/01r5integ    |    6 +++---
 tests/01raid6integ |   10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/01r5integ b/tests/01r5integ
index 714a57f..97a71f3 100644
--- a/tests/01r5integ
+++ b/tests/01r5integ
@@ -1,7 +1,7 @@
 
 # Check integrity of raid5 in degraded mode
 # Create a 4 disk raid5, create a filesystem and
-# sh1sum it with each device failed
+# sha1sum it with each device failed
 
 for layout in ls rs la ra
 do
@@ -16,9 +16,9 @@ do
     mdadm $md0 -r $i
     blockdev --flushbufs $md0
     sum1=`sha1sum $md0`
-    if [ $sum != $sum1 ]
+    if [ "$sum" != "$sum1" ]
     then
-     echo $sum does not matc $sum1 with $i missing
+     echo $sum does not match $sum1 with $i missing
      exit 1
     fi
     mdadm $md0 -a $i
diff --git a/tests/01raid6integ b/tests/01raid6integ
index 245b0da..7123e2b 100644
--- a/tests/01raid6integ
+++ b/tests/01raid6integ
@@ -1,7 +1,7 @@
 
 # Check integrity of raid6 in degraded modes
 # Create a 5 disk raid6, dump some data to it, then
-# sh1sum it with different pairs of devices failed
+# sha1sum it with different pairs of devices failed
 
 layouts='ls rs la ra'
 lv=`uname -r`
@@ -25,9 +25,9 @@ do
     mdadm $md0 -r $second
     blockdev --flushbufs $md0
     sum1=`sha1sum $md0`
-    if [ $sum != $sum1 ]
+    if [ "$sum" != "$sum1" ]
     then
-      echo $sum does not matc $sum1 with $second missing
+      echo $sum does not match $sum1 with $second missing
       exit 1
     fi
     for first in $totest
@@ -36,9 +36,9 @@ do
        mdadm $md0 -r $first
        blockdev --flushbufs $md0
        sum1=`sha1sum $md0`
-       if [ $sum != $sum1 ]
+       if [ "$sum" != "$sum1" ]
        then
-         echo $sum does not matc $sum1 with $first and $second missing
+         echo $sum does not match $sum1 with $first and $second missing
          exit 1
        fi
        mdadm $md0 -a $first
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-10-10 23:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-10 11:38 [PATCH] Fix tests sh too many arguments warnings Gilles Espinasse
2012-10-10 23:39 ` NeilBrown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).