From: Jes.Sorensen@redhat.com
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, dledford@redhat.com, harald@redhat.com
Subject: [PATCH 3/3] execl() only returns in case of error
Date: Mon, 21 Jan 2013 14:22:58 +0100 [thread overview]
Message-ID: <1358774578-2183-4-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1358774578-2183-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
In case exec fails, fall through and print warning rather than just
calling exit(1) silently.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
util.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util.c b/util.c
index 500b2bd..68fd27e 100644
--- a/util.c
+++ b/util.c
@@ -1705,7 +1705,6 @@ int start_mdmon(int devnum)
}
}
}
- exit(1);
case -1: pr_err("cannot run mdmon. "
"Array remains readonly\n");
return -1;
--
1.7.11.7
next prev parent reply other threads:[~2013-01-21 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 13:22 [PATCH v2 0/3] support launching mdmon via systemctl Jes.Sorensen
2013-01-21 13:22 ` [PATCH 1/3] Add support for launching mdmon via systemctl instead of fork/exec Jes.Sorensen
2013-01-22 5:46 ` NeilBrown
2013-01-22 7:33 ` Jes Sorensen
2013-01-25 11:13 ` Jes Sorensen
2013-01-25 15:05 ` Jes Sorensen
2013-01-21 13:22 ` [PATCH 2/3] systemd .service files for launching mdmon via systemctl Jes.Sorensen
2013-01-21 13:22 ` Jes.Sorensen [this message]
2013-01-22 5:48 ` [PATCH 3/3] execl() only returns in case of error NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358774578-2183-4-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=harald@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).