From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Menzel <pm.debian@googlemail.com>
Subject: Re: [PATCH linux-next] DM RAID: validate_raid_redundancy: Silence
 uninitialized variable warning
Date: Wed, 20 Feb 2013 23:18:45 +0100
Message-ID: <1361398725.4895.27.camel@mattotaupa>
References: <1361392278-59767-1-git-send-email-tim.gardner@canonical.com>
	 <1361398597.4895.24.camel@mattotaupa>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-m0Bqxe9YQf/ZrhncsAvk"
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1361398597.4895.24.camel@mattotaupa>
Sender: linux-kernel-owner@vger.kernel.org
To: Tim Gardner <tim.gardner@canonical.com>
Cc: linux-kernel@vger.kernel.org, Alasdair Kergon <agk@redhat.com>, dm-devel@redhat.com, Neil Brown <neilb@suse.de>, linux-raid@vger.kernel.org
List-Id: linux-raid.ids


--=-m0Bqxe9YQf/ZrhncsAvk
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dear Tim,


Am Mittwoch, den 20.02.2013, 23:16 +0100 schrieb Paul Menzel:

> Am Mittwoch, den 20.02.2013, 13:31 -0700 schrieb Tim Gardner:
>=20
> Noting the `gcc` version and build environment is never wrong. ;-)
>=20
> > drivers/md/dm-raid.c: In function 'raid_ctr':
> > drivers/md/dm-raid.c:453:53: warning: 'rebuilds_per_group' may be used =
uninitialized in this function [-Wuninitialized]
> > drivers/md/dm-raid.c:383:11: note: 'rebuilds_per_group' was declared he=
re
> >=20
> > It appears unlikely that rebuilds_per_group could be used before set,
>=20
> Why? Otherwise the compiler would not complain, right?
>=20
> > but set it to 0 anyways just to shutup GCC.
>=20
> Unfortunately I do not know what linux-next version you tested, so the
> line numbers are off in.
>=20
>         $ git describe
>         v3.7.5-4-g9c2ab66

See below =E2=80=A6

> > Cc: Alasdair Kergon <agk@redhat.com>
> > Cc: dm-devel@redhat.com
> > Cc: Neil Brown <neilb@suse.de>
> > Cc: linux-raid@vger.kernel.org
> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> > ---
> >  drivers/md/dm-raid.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> > index 9d6bf19..8005caf 100644

Git to the rescue. I guess I should be able to find that commit to make
sense of the line numbers.

> > --- a/drivers/md/dm-raid.c
> > +++ b/drivers/md/dm-raid.c
> > @@ -380,7 +380,7 @@ static int validate_region_size(struct raid_set *rs=
, unsigned long region_size)
> >  static int validate_raid_redundancy(struct raid_set *rs)
> >  {
> >  	unsigned i, rebuild_cnt =3D 0;
> > -	unsigned rebuilds_per_group, copies, d;
> > +	unsigned rebuilds_per_group =3D 0, copies, d;
> >  	unsigned group_size, last_group_start;
> > =20
> >  	for (i =3D 0; i < rs->md.raid_disks; i++)


Thanks,

Paul

--=-m0Bqxe9YQf/ZrhncsAvk
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEABECAAYFAlElS8UACgkQPX1aK2wOHVjShACfZ44+CBAzUUudihswlpYeyOxV
hzwAnjdaFOqXDPfB6FH7JshK7c2iNFI8
=X7l1
-----END PGP SIGNATURE-----

--=-m0Bqxe9YQf/ZrhncsAvk--