From: Jonathan Brassow <jbrassow@redhat.com>
To: linux-raid@vger.kernel.org
Cc: neilb@suse.de, jbrassow@redhat.com
Subject: [PATCH] DM RAID: Explicitly turn off bad block support
Date: Fri, 19 Apr 2013 08:30:24 -0500 [thread overview]
Message-ID: <1366378224.14427.1.camel@f16> (raw)
DM RAID: Explicitly turn off bad block support
DM RAID does not currently use the bad block tracking available in
MD. 'badblocks.shift' must be set to '-1' in order to explicitly
tell MD not to perform bad block related functions, like
narrow_write_error().
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-upstream/drivers/md/dm-raid.c
===================================================================
--- linux-upstream.orig/drivers/md/dm-raid.c
+++ linux-upstream/drivers/md/dm-raid.c
@@ -170,8 +170,10 @@ static struct raid_set *context_alloc(st
rs->md.delta_disks = 0;
rs->md.recovery_cp = 0;
- for (i = 0; i < raid_devs; i++)
+ for (i = 0; i < raid_devs; i++) {
md_rdev_init(&rs->dev[i].rdev);
+ rs->dev[i].rdev.badblocks.shift = -1; /* No bad block support */
+ }
/*
* Remaining items to be initialized by further RAID params:
next reply other threads:[~2013-04-19 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 13:30 Jonathan Brassow [this message]
2013-04-22 0:52 ` [PATCH] DM RAID: Explicitly turn off bad block support NeilBrown
2013-04-22 16:29 ` Brassow Jonathan
2013-04-23 0:05 ` NeilBrown
2013-04-24 3:48 ` Brassow Jonathan
2013-04-24 6:24 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1366378224.14427.1.camel@f16 \
--to=jbrassow@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox