linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mwilck@arcor.de
To: neilb@suse.de, linux-raid@vger.kernel.org
Cc: mwilck@arcor.de
Subject: [RFC/PATCH 0/6] DDF: safe big-endian types
Date: Sun, 21 Jul 2013 19:28:18 +0200	[thread overview]
Message-ID: <1374427704-7903-1-git-send-email-mwilck@arcor.de> (raw)

Hi Neil, hello list,

please review this patch series. I made so many endianness bugs
while working on DDF during the last months that I thought this
might be helpful - it will cause bugs to be caught by the
compiler which may otherwise turn up as hard-to-find runtime errors.

Note that the code  *does not* compile after each patch, only 
after the last one. I broke it down to make it more readable.

Patch 0005 and 0006 are separate because they are actual minor bugs
in the code that the endianness patch set helped me find.

I verified that the DDF unit tests aren't broken by this patch set.

Martin

Martin Wilck (6):
  DDF: add endian-safe typedefs
  DDF: convert big endian to be32 type
  DDF: convert big-endian __u64 to be64 type
  DDF: convert big-endian __u16 to be16 type
  DDF: add_other_bvd: fix endianness bug
  DDF: ddf_set_disk: fix minor endianness bug

 super-ddf.c |  851 ++++++++++++++++++++++++++++++++---------------------------
 1 files changed, 462 insertions(+), 389 deletions(-)

             reply	other threads:[~2013-07-21 17:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21 17:28 mwilck [this message]
2013-07-21 17:28 ` [PATCH 1/6] DDF: add endian-safe typedefs mwilck
2013-07-21 17:28 ` [PATCH 2/6] DDF: convert big endian to be32 type mwilck
2013-07-21 17:28 ` [PATCH 3/6] DDF: convert big-endian __u64 to be64 type mwilck
2013-07-21 17:28 ` [PATCH 4/6] DDF: convert big-endian __u16 to be16 type mwilck
2013-07-21 17:28 ` [PATCH 5/6] DDF: add_other_bvd: fix endianness bug mwilck
2013-07-21 17:28 ` [PATCH 6/6] DDF: ddf_set_disk: fix minor " mwilck
2013-07-23  4:06 ` [RFC/PATCH 0/6] DDF: safe big-endian types NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1374427704-7903-1-git-send-email-mwilck@arcor.de \
    --to=mwilck@arcor.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).