linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: mwilck@arcor.de
To: neilb@suse.de, linux-raid@vger.kernel.org
Cc: mwilck@arcor.de
Subject: Fixes for DDF test case (race conditions in mdmon)
Date: Mon, 25 Mar 2013 23:10:58 +0000 (UTC)
Date: Fri, 25 Oct 2013 12:07:31 +0200	[thread overview]
Message-ID: <1382695659-6231-1-git-send-email-mwilck@arcor.de> (raw)

This is a series of patches to fix the DDF tests case(tests/10ddf-create).

Patch 3 fixes a problem that was implicitly introduced by commit 
c1ea5a98 - "mdadm -Db" would now print UUIDs for subarrays, but the
wrong ones.

Patch 5-7 are the interesting part. The DDF test case kept failing for
me right there where a comment already says "# This failed once. 
The raid5 was resyncing". I tracked this down to race conditions
between mdmon and the kernel when arrays are stopped - the kernel
cleans up in sysfs and reading the attributes from there is unreliable.
Files may have already vanished, read() may fail or even succeed
with incorrect results.

The other patches are hopefully self-explaining.

Regards
Martin

Martin Wilck (8):
  DDF: __write_ddf_structure: Fix wrong reference to ddf->primary
  DDF: __write_init_super_ddf: just use seq number of active header
  DDF: brief_detail_super_ddf: print correct UUID for subarrays
  DDF: add code to debug state changes
  monitor: don't call pselect() on deleted sysfs files
  monitor: read_and_act: handle race conditions for resync_start
  monitor: treat unreadable array_state as clean
  tests/10ddf-create: omit log output check

 monitor.c          |   38 ++++++++++++----
 super-ddf.c        |  124 ++++++++++++++++++++++++++++++++++++++-------------
 tests/10ddf-create |    6 +--
 3 files changed, 121 insertions(+), 47 deletions(-)

             reply	other threads:[~2013-03-25 23:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-25 23:10 mwilck [this message]
2013-03-25 23:11 ` [PATCH 1/8] DDF: __write_ddf_structure: Fix wrong reference to ddf->primary mwilck
2013-03-25 23:11 ` [PATCH 2/8] DDF: __write_init_super_ddf: just use seq number of active header mwilck
2013-03-25 23:11 ` [PATCH 4/8] DDF: add code to debug state changes mwilck
2013-03-25 23:11 ` [PATCH 3/8] DDF: brief_detail_super_ddf: print correct UUID for subarrays mwilck
2013-03-25 23:11 ` [PATCH 8/8] tests/10ddf-create: omit log output check mwilck
2013-03-25 23:11 ` [PATCH 7/8] monitor: treat unreadable array_state as clean mwilck
2013-03-25 23:11 ` [PATCH 5/8] monitor: don't call pselect() on deleted sysfs files mwilck
2013-03-25 23:11 ` [PATCH 6/8] monitor: read_and_act: handle race conditions for resync_start mwilck
2013-04-23  7:15 ` Fixes for DDF test case (race conditions in mdmon) NeilBrown
2013-04-23 17:30   ` Martin Wilck
2013-04-23 18:10   ` [PATCH] DDF: fix bug in compare_super_ddf mwilck
2013-04-24  6:34     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382695659-6231-1-git-send-email-mwilck@arcor.de \
    --to=mwilck@arcor.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).