linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: behanw@converseincode.com
To: agk@redhat.com, clm@fb.com, davem@davemloft.net,
	dm-devel@redhat.com, fabf@skynet.be, herbert@gondor.apana.org.au,
	jbacik@fb.com, snitzer@redhat.com, tadeusz.struk@intel.com
Cc: thomas.lendacky@amd.com, linux-ima-user@lists.sourceforge.net,
	qat-linux@intel.com, d.kasatkin@samsung.com,
	bruce.w.allan@intel.com, linux-kernel@vger.kernel.org,
	john.griffin@intel.com, linux-raid@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Behan Webster <behanw@converseincode.com>,
	linux-crypto@vger.kernel.org, james.l.morris@oracle.com,
	torvalds@linux-foundation.org,
	linux-ima-devel@lists.sourceforge.net, akpm@linux-foundation.org,
	zohar@linux.vnet.ibm.com, linux-btrfs@vger.kernel.org,
	serge@hallyn.com
Subject: [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code
Date: Mon, 15 Sep 2014 00:30:23 -0700	[thread overview]
Message-ID: <1410766234-1634-2-git-send-email-behanw@converseincode.com> (raw)
In-Reply-To: <1410766234-1634-1-git-send-email-behanw@converseincode.com>

From: Behan Webster <behanw@converseincode.com>

Add a macro which replaces the use of a Variable Length Array In Struct (VLAIS)
with a C99 compliant equivalent. This macro instead allocates the appropriate
amount of memory using an char array.

The new code can be compiled with both gcc and clang.

struct shash_desc contains a flexible array member member ctx declared with
CRYPTO_MINALIGN_ATTR, so sizeof(struct shash_desc) aligns the beginning
of the array declared after struct shash_desc with long long.

No trailing padding is required because it is not a struct type that can
be used in an array.

The CRYPTO_MINALIGN_ATTR is required so that desc is aligned with long long
as would be the case for a struct containing a member with
CRYPTO_MINALIGN_ATTR.

Signed-off-by: Behan Webster <behanw@converseincode.com>
---
 include/crypto/hash.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/crypto/hash.h b/include/crypto/hash.h
index a391955..541125b 100644
--- a/include/crypto/hash.h
+++ b/include/crypto/hash.h
@@ -58,6 +58,11 @@ struct shash_desc {
 	void *__ctx[] CRYPTO_MINALIGN_ATTR;
 };
 
+#define SHASH_DESC_ON_STACK(shash, tfm)				  \
+	char __desc[sizeof(struct shash_desc) +                   \
+		crypto_shash_descsize(tfm)] CRYPTO_MINALIGN_ATTR; \
+	struct shash_desc *shash = (struct shash_desc *)__desc
+
 struct shash_alg {
 	int (*init)(struct shash_desc *desc);
 	int (*update)(struct shash_desc *desc, const u8 *data,
-- 
1.9.1

  reply	other threads:[~2014-09-15  7:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-15  7:30 [PATCH v3 00/12] LLVMLinux: Patches to enable the kernel to be compiled with clang/LLVM behanw
2014-09-15  7:30 ` behanw [this message]
2014-09-15  8:06   ` [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code Michał Mirosław
2014-09-15  8:37     ` Behan Webster
2014-09-17  9:22   ` Herbert Xu
2014-09-17 11:15     ` Dmitry Kasatkin
2014-09-17 11:30       ` Herbert Xu
2014-09-17 15:26         ` Behan Webster
2014-09-15  7:30 ` [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS behanw
2014-09-17 13:49   ` Chris Mason
2014-09-15  7:30 ` [PATCH v3 03/12] crypto: LLVMLinux: Remove VLAIS from crypto/ccp/ccp-crypto-sha.c behanw
2014-09-15  7:30 ` [PATCH v3 04/12] crypto: LLVMLinux: Remove VLAIS from crypto/mv_cesa.c behanw
2014-09-15  7:30 ` [PATCH v3 05/12] crypto: LLVMLinux: Remove VLAIS from crypto/n2_core.c behanw
2014-09-15  7:30 ` [PATCH v3 06/12] crypto: LLVMLinux: Remove VLAIS from crypto/omap_sham.c behanw
2014-09-15  7:30 ` [PATCH v3 07/12] crypto: LLVMLinux: Remove VLAIS from crypto/.../qat_algs.c behanw
2014-09-15  7:30 ` [PATCH v3 08/12] crypto, dm: LLVMLinux: Remove VLAIS usage from dm-crypt behanw
2014-09-15  7:30 ` [PATCH v3 09/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/hmac.c behanw
2014-09-15  7:30 ` [PATCH v3 10/12] crypto: LLVMLinux: Remove VLAIS usage from libcrc32c.c behanw
2014-09-15  7:30 ` [PATCH v3 11/12] security, crypto: LLVMLinux: Remove VLAIS from ima_crypto.c behanw
2014-09-15 14:21   ` Linus Torvalds
2014-09-15 14:25     ` Behan Webster
2014-09-15  7:30 ` [PATCH v3 12/12] crypto: LLVMLinux: Remove VLAIS usage from crypto/testmgr.c behanw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410766234-1634-2-git-send-email-behanw@converseincode.com \
    --to=behanw@converseincode.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bruce.w.allan@intel.com \
    --cc=clm@fb.com \
    --cc=d.kasatkin@samsung.com \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=fabf@skynet.be \
    --cc=herbert@gondor.apana.org.au \
    --cc=james.l.morris@oracle.com \
    --cc=jbacik@fb.com \
    --cc=john.griffin@intel.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-ima-user@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=qat-linux@intel.com \
    --cc=serge@hallyn.com \
    --cc=snitzer@redhat.com \
    --cc=tadeusz.struk@intel.com \
    --cc=thomas.lendacky@amd.com \
    --cc=torvalds@linux-foundation.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).