linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nicholas Krause <xerofoify@gmail.com>
To: agk@redhat.com
Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com,
	linux-kernel@vger.kernel.org, snitzer@redhat.com
Subject: [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region
Date: Mon, 19 Jan 2015 22:16:21 -0500	[thread overview]
Message-ID: <1421723781-21984-1-git-send-email-xerofoify@gmail.com> (raw)

Removes the no longer needed fix me comment questioning if we need to remove
the structure pointer,rh as defined as a structure of type dsm_region_hash
from the definition of the structure, dm_region. Furthermore this  pointer is
needed in order for various functions to run and build successfully in the file,
dm-region-hash.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 drivers/md/dm-region-hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-region-hash.c b/drivers/md/dm-region-hash.c
index b929fd5..823d56f 100644
--- a/drivers/md/dm-region-hash.c
+++ b/drivers/md/dm-region-hash.c
@@ -99,7 +99,7 @@ struct dm_region_hash {
 };
 
 struct dm_region {
-	struct dm_region_hash *rh;	/* FIXME: can we get rid of this ? */
+	struct dm_region_hash *rh;
 	region_t key;
 	int state;
 
-- 
2.1.0

             reply	other threads:[~2015-01-20  3:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  3:16 Nicholas Krause [this message]
2015-01-20 11:19 ` [dm-devel] [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region Alasdair G Kergon
2015-01-20 11:36   ` nick
2015-01-20 11:40     ` [dm-devel] " Alasdair G Kergon
2015-01-20 13:17       ` Nick Krause
2015-01-26 20:09         ` Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421723781-21984-1-git-send-email-xerofoify@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).