From: Nicholas Krause <xerofoify@gmail.com>
To: agk@redhat.com
Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, snitzer@redhat.com
Subject: [PATCH] md:Remove unneeded fixme comment for the function, pool_ctr
Date: Sat, 31 Jan 2015 00:36:42 -0500 [thread overview]
Message-ID: <1422682602-5856-1-git-send-email-xerofoify@gmail.com> (raw)
Removes the no longer needed fix me comment for removing the validation check
for the number of agruments passed by the caller to outside the mutex_lock in
the function,pool_ctr. This comment is no longer needed as we will clearly jump
to the out_lock block of this function if the validation fails and therefore this
is no real concern for holding the mutex lock longer then required if the validation
check for number of agruments from the caller of fails.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
drivers/md/dm-thin.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index 07705ee..7d22334 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -2849,9 +2849,6 @@ static int pool_ctr(struct dm_target *ti, unsigned argc, char **argv)
struct dm_dev *metadata_dev;
fmode_t metadata_mode;
- /*
- * FIXME Remove validation from scope of lock.
- */
mutex_lock(&dm_thin_pool_table.mutex);
if (argc < 4) {
--
2.1.0
reply other threads:[~2015-01-31 5:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422682602-5856-1-git-send-email-xerofoify@gmail.com \
--to=xerofoify@gmail.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).