From: Firo Yang <firogm@gmail.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org,
Firo Yang <firogm@gmail.com>
Subject: [PATCH] md: fix a build warning
Date: Wed, 10 Jun 2015 23:20:58 +0800 [thread overview]
Message-ID: <1433949658-8455-1-git-send-email-firogm@gmail.com> (raw)
Warning like this:
drivers/md/md.c: In function ‘update_array_info’:
drivers/md/md.c:6394:26: warning: logical not is only applied
to the left hand side of comparison [-Wlogical-not-parentheses]
!mddev->persistent != info->not_persistent||
I fix it by enclosing !mddev->persistent with parentheses
By the way, I also fixed a line over 80 characters warning outputed
by ./scripts/checkpatch.pl
Signed-off-by: Firo Yang <firogm@gmail.com>
---
drivers/md/md.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index dd85be9..b420d82 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6391,9 +6391,10 @@ static int update_array_info(struct mddev *mddev, mdu_array_info_t *info)
mddev->ctime != info->ctime ||
mddev->level != info->level ||
/* mddev->layout != info->layout || */
- !mddev->persistent != info->not_persistent||
+ (!mddev->persistent) != info->not_persistent ||
mddev->chunk_sectors != info->chunk_size >> 9 ||
- /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to change */
+ /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT
+ to change */
((state^info->state) & 0xfffffe00)
)
return -EINVAL;
--
2.4.2
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2015-06-10 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 15:20 Firo Yang [this message]
2015-06-10 16:07 ` [PATCH] md: fix a build warning Dan Carpenter
2015-06-10 17:32 ` walter harms
2015-06-10 17:36 ` Julia Lawall
2015-06-10 18:04 ` walter harms
2015-06-10 20:38 ` Neil Brown
2015-06-10 20:34 ` Neil Brown
2015-06-11 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433949658-8455-1-git-send-email-firogm@gmail.com \
--to=firogm@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).