From mboxrd@z Thu Jan 1 00:00:00 1970 From: Firo Yang Subject: [PATCH] md: fix a build warning Date: Wed, 10 Jun 2015 23:20:58 +0800 Message-ID: <1433949658-8455-1-git-send-email-firogm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Sender: kernel-janitors-owner@vger.kernel.org To: neilb@suse.de Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org, Firo Yang List-Id: linux-raid.ids Warning like this: drivers/md/md.c: In function =E2=80=98update_array_info=E2=80=99: drivers/md/md.c:6394:26: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] !mddev->persistent !=3D info->not_persistent|| I fix it by enclosing !mddev->persistent with parentheses By the way, I also fixed a line over 80 characters warning outputed by ./scripts/checkpatch.pl Signed-off-by: Firo Yang --- drivers/md/md.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index dd85be9..b420d82 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6391,9 +6391,10 @@ static int update_array_info(struct mddev *mddev= , mdu_array_info_t *info) mddev->ctime !=3D info->ctime || mddev->level !=3D info->level || /* mddev->layout !=3D info->layout || */ - !mddev->persistent !=3D info->not_persistent|| + (!mddev->persistent) !=3D info->not_persistent || mddev->chunk_sectors !=3D info->chunk_size >> 9 || - /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT to = change */ + /* ignore bottom 8 bits of state, and allow SB_BITMAP_PRESENT + to change */ ((state^info->state) & 0xfffffe00) ) return -EINVAL; --=20 2.4.2 -- To unsubscribe from this list: send the line "unsubscribe kernel-janito= rs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html