linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Shaohua Li <shli@fb.com>, neilb@suse.de
Cc: linux-raid@vger.kernel.org, Kernel-team@fb.com, dan.j.williams@intel.com
Subject: [PATCH 06/10] raid5-cache: take rdev->data_offset into account early on
Date: Mon,  7 Sep 2015 07:20:46 +0200	[thread overview]
Message-ID: <1441603250-5119-7-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1441603250-5119-1-git-send-email-hch@lst.de>

Set up bi_sector properly when we allocate an bio instead of updating it
at submission time.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/raid5-cache.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
index d0ad798..df79d49 100644
--- a/drivers/md/raid5-cache.c
+++ b/drivers/md/raid5-cache.c
@@ -238,11 +238,8 @@ static void r5l_submit_current_io(struct r5l_log *log)
 	__r5l_set_io_unit_state(io, IO_UNIT_IO_START);
 	spin_unlock_irqrestore(&log->io_list_lock, flags);
 
-	while ((bio = bio_list_pop(&io->bios))) {
-		/* all IO must start from rdev->data_offset */
-		bio->bi_iter.bi_sector += log->rdev->data_offset;
+	while ((bio = bio_list_pop(&io->bios)))
 		submit_bio(WRITE | REQ_FUA, bio);
-	}
 }
 
 static struct bio *r5l_bio_alloc(struct r5l_log *log, struct r5l_io_unit *io)
@@ -251,7 +248,7 @@ static struct bio *r5l_bio_alloc(struct r5l_log *log, struct r5l_io_unit *io)
 
 	bio->bi_rw = WRITE;
 	bio->bi_bdev = log->rdev->bdev;
-	bio->bi_iter.bi_sector = log->log_start;
+	bio->bi_iter.bi_sector = log->rdev->data_offset + log->log_start;
 	bio->bi_end_io = r5l_log_endio;
 	bio->bi_private = io;
 
-- 
1.9.1


  parent reply	other threads:[~2015-09-07  5:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07  5:20 raid5-cache I/O path improvements Christoph Hellwig
2015-09-07  5:20 ` [PATCH 01/10] raid5-cache: port to 4.3-rc Christoph Hellwig
2015-09-07  5:20 ` [PATCH 02/10] raid5-cache: free I/O units earlier Christoph Hellwig
2015-09-07  5:20 ` [PATCH 03/10] raid5-cache: use FUA writes for the log Christoph Hellwig
2015-09-07  5:20 ` [PATCH 04/10] raid5-cache: clean up r5l_get_meta Christoph Hellwig
2015-09-07  5:20 ` [PATCH 05/10] raid5-cache: refactor bio allocation Christoph Hellwig
2015-09-07  5:20 ` Christoph Hellwig [this message]
2015-09-07  5:20 ` [PATCH 07/10] raid5-cache: inline r5l_alloc_io_unit into r5l_new_meta Christoph Hellwig
2015-09-07  5:20 ` [PATCH 08/10] raid5-cache: new helper: r5_reserve_log_entry Christoph Hellwig
2015-09-07  5:20 ` [PATCH 09/10] raid5-cache: small log->seq cleanup Christoph Hellwig
2015-09-07  5:20 ` [PATCH 10/10] raid5-cache: use bio chaining Christoph Hellwig
2015-09-08  0:28 ` raid5-cache I/O path improvements Shaohua Li
2015-09-08  6:12   ` Christoph Hellwig
2015-09-08 15:25     ` Tejun Heo
2015-09-08 15:26       ` Tejun Heo
2015-09-08 15:40       ` Christoph Hellwig
2015-09-08 16:56     ` Shaohua Li
2015-09-08 17:02       ` Tejun Heo
2015-09-08 17:07         ` Shaohua Li
2015-09-08 17:34           ` Tejun Heo
2015-09-09 15:59             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441603250-5119-7-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=Kernel-team@fb.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=shli@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).