* [PATCH] dm snapshot: fix memory leak in error path
@ 2015-10-13 12:36 Michael Opdenacker
0 siblings, 0 replies; only message in thread
From: Michael Opdenacker @ 2015-10-13 12:36 UTC (permalink / raw)
To: agk, snitzer
Cc: dm-devel, neilb, linux-raid, linux-kernel, Michael Opdenacker
Fix a memory leak in an error path (reported by Coverity CID 1326059)
Also add a missing workqueue deallocation in the same error path.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
drivers/md/dm-snap-persistent.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/dm-snap-persistent.c b/drivers/md/dm-snap-persistent.c
index aeacad9be51d..1e980fa8bb8b 100644
--- a/drivers/md/dm-snap-persistent.c
+++ b/drivers/md/dm-snap-persistent.c
@@ -879,6 +879,8 @@ static int persistent_ctr(struct dm_exception_store *store, char *options)
store->userspace_supports_overflow = true;
else {
DMERR("Unsupported persistent store option: %s", options);
+ destroy_workqueue(ps->metadata_wq);
+ kfree(ps);
return -EINVAL;
}
}
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-13 12:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-13 12:36 [PATCH] dm snapshot: fix memory leak in error path Michael Opdenacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).