* [PATCH] Makefile: make the CC definition conditional
@ 2016-02-08 9:59 Maxin B. John
2016-02-08 15:55 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Maxin B. John @ 2016-02-08 9:59 UTC (permalink / raw)
To: linux-raid; +Cc: Maxin B. John
From: "Maxin B. John" <maxin.john@intel.com>
By hardcoding CC's definition in the Makefile, all the external gcc
parameters set by tune settings are lost. This causes compile failure
with x32 toolchain
Signed-off-by: Maxin B. John <maxin.john@intel.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index fd79cfb..5fd7f16 100644
--- a/Makefile
+++ b/Makefile
@@ -41,7 +41,7 @@ KLIBC=/home/src/klibc/klibc-0.77
KLIBC_GCC = gcc -nostdinc -iwithprefix include -I$(KLIBC)/klibc/include -I$(KLIBC)/linux/include -I$(KLIBC)/klibc/arch/i386/include -I$(KLIBC)/klibc/include/bits32
-CC = $(CROSS_COMPILE)gcc
+CC ?= $(CROSS_COMPILE)gcc
CXFLAGS ?= -ggdb
CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter
ifdef WARN_UNUSED
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Makefile: make the CC definition conditional
2016-02-08 9:59 [PATCH] Makefile: make the CC definition conditional Maxin B. John
@ 2016-02-08 15:55 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2016-02-08 15:55 UTC (permalink / raw)
To: Maxin B. John; +Cc: linux-raid, Maxin B. John
"Maxin B. John" <maxin.john@gmail.com> writes:
> From: "Maxin B. John" <maxin.john@intel.com>
>
> By hardcoding CC's definition in the Makefile, all the external gcc
> parameters set by tune settings are lost. This causes compile failure
> with x32 toolchain
>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied!
Thanks,
Jes
> diff --git a/Makefile b/Makefile
> index fd79cfb..5fd7f16 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -41,7 +41,7 @@ KLIBC=/home/src/klibc/klibc-0.77
>
> KLIBC_GCC = gcc -nostdinc -iwithprefix include
> -I$(KLIBC)/klibc/include -I$(KLIBC)/linux/include
> -I$(KLIBC)/klibc/arch/i386/include -I$(KLIBC)/klibc/include/bits32
>
> -CC = $(CROSS_COMPILE)gcc
> +CC ?= $(CROSS_COMPILE)gcc
> CXFLAGS ?= -ggdb
> CWFLAGS = -Wall -Werror -Wstrict-prototypes -Wextra -Wno-unused-parameter
> ifdef WARN_UNUSED
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-08 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-08 9:59 [PATCH] Makefile: make the CC definition conditional Maxin B. John
2016-02-08 15:55 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).