From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: [V2 PATCH 13/13] md-cluster: fix ifnullfree.cocci warnings Date: Mon, 2 May 2016 11:50:16 -0400 Message-ID: <1462204216-2269-6-git-send-email-gqjiang@suse.com> References: <1462203200-1375-1-git-send-email-gqjiang@suse.com> <1462204216-2269-1-git-send-email-gqjiang@suse.com> Return-path: In-Reply-To: <1462204216-2269-1-git-send-email-gqjiang@suse.com> Sender: linux-raid-owner@vger.kernel.org To: shli@kernel.org Cc: neilb@suse.de, linux-raid@vger.kernel.org, kbuild test robot , Fengguang Wu List-Id: linux-raid.ids From: kbuild test robot drivers/md/bitmap.c:2049:6-11: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Acked-by: Guoqing Jiang Signed-off-by: Fengguang Wu --- drivers/md/bitmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 4a05bac..ad5a858 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c @@ -2076,8 +2076,7 @@ int bitmap_resize(struct bitmap *bitmap, sector_t blocks, /* deallocate the page memory */ for (k = 0; k < page; k++) { - if (new_bp[k].map) - kfree(new_bp[k].map); + kfree(new_bp[k].map); } /* restore some fields from old_counts */ -- 2.6.6