From: Guoqing Jiang <gqjiang@suse.com>
To: Jes.Sorensen@redhat.com
Cc: linux-raid@vger.kernel.org, Guoqing Jiang <gqjiang@suse.com>
Subject: [PATCH 2/2] super1: don't update node nums if it is not more than 1
Date: Wed, 4 May 2016 16:33:44 +0800 [thread overview]
Message-ID: <1462350824-9872-3-git-send-email-gqjiang@suse.com> (raw)
In-Reply-To: <1462350824-9872-1-git-send-email-gqjiang@suse.com>
We at least need two nodes for cluster raid so make the
check before update node nums.
Reported-by: Zhilong Liu <zlliu@suse.com>
Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
---
super1.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/super1.c b/super1.c
index 8d5543f..972b470 100644
--- a/super1.c
+++ b/super1.c
@@ -2394,6 +2394,11 @@ static int write_bitmap1(struct supertype *st, int fd, enum bitmap_update update
return -EINVAL;
}
+ if (bms->version == BITMAP_MAJOR_CLUSTERED && st->nodes <= 1) {
+ pr_err("Warning: cluster-md at least needs two nodes\n");
+ return -EINVAL;
+ }
+
/* Each node has an independent bitmap, it is necessary to calculate the
* space is enough or not, first get how many bytes for the total bitmap */
bm_space_per_node = calc_bitmap_size(bms, 4096);
--
2.6.2
next prev parent reply other threads:[~2016-05-04 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 8:33 [PATCH 0/2] Check node nums for cluster raid Guoqing Jiang
2016-05-04 8:33 ` [PATCH 1/2] Create: check the node nums when create clustered raid Guoqing Jiang
2016-05-04 8:33 ` Guoqing Jiang [this message]
2016-05-04 15:12 ` [PATCH 0/2] Check node nums for cluster raid Jes Sorensen
2016-05-04 15:19 ` Doug Ledford
2016-05-04 15:25 ` Jes Sorensen
2016-05-04 15:28 ` Doug Ledford
2016-05-05 3:03 ` Guoqing Jiang
2016-05-05 20:28 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462350824-9872-3-git-send-email-gqjiang@suse.com \
--to=gqjiang@suse.com \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).