From: Song Liu <songliubraving@fb.com>
To: linux-raid@vger.kernel.org
Cc: Jes.Sorensen@redhat.com, Song Liu <songliubraving@fb.com>
Subject: [PATCH v2] mdadm: replace hard coded string length
Date: Fri, 16 Sep 2016 08:51:51 -0700 [thread overview]
Message-ID: <1474041111-4029795-1-git-send-email-songliubraving@fb.com> (raw)
This patch replaces hard coded 32 with sizeof(sb->set_name) in a
couple places.
Signed-off-by: Song Liu <songliubraving@fb.com>
---
super1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/super1.c b/super1.c
index 9f62d23..729596f 100644
--- a/super1.c
+++ b/super1.c
@@ -1030,7 +1030,7 @@ static void getinfo_super1(struct supertype *st, struct mdinfo *info, char *map)
memcpy(info->uuid, sb->set_uuid, 16);
- strncpy(info->name, sb->set_name, 32);
+ strncpy(info->name, sb->set_name, sizeof(info->name) - 1);
info->name[32] = 0;
if ((__le32_to_cpu(sb->feature_map)&MD_FEATURE_REPLACEMENT)) {
@@ -1124,7 +1124,7 @@ static int update_super1(struct supertype *st, struct mdinfo *info,
if (c)
strncpy(info->name, c+1, 31 - (c-sb->set_name));
else
- strncpy(info->name, sb->set_name, 32);
+ strncpy(info->name, sb->set_name, sizeof(info->name) - 1);
info->name[32] = 0;
}
--
2.8.0.rc2
next reply other threads:[~2016-09-16 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 15:51 Song Liu [this message]
2016-09-17 21:06 ` [PATCH v2] mdadm: replace hard coded string length Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474041111-4029795-1-git-send-email-songliubraving@fb.com \
--to=songliubraving@fb.com \
--cc=Jes.Sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox