From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 01/10] dm snapshot: Use kmalloc_array() in init_origin_hash() Date: Thu, 29 Sep 2016 08:01:10 -0700 Message-ID: <1475161270.2027.5.camel@perches.com> References: <566ABCD9.1060404@users.sourceforge.net> <080668d9-1e1e-e208-f9ea-ff718e8070e5@users.sourceforge.net> <3861d349-48fd-162b-a749-83e007f70b41@users.sourceforge.net> <1475142864.31297.5.camel@tiscali.nl> <1475143376.1946.2.camel@perches.com> <1475147577.31297.11.camel@tiscali.nl> <1475149503.31297.14.camel@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1475149503.31297.14.camel@tiscali.nl> Sender: linux-kernel-owner@vger.kernel.org To: Paul Bolle , Andy Whitcroft Cc: SF Markus Elfring , dm-devel@redhat.com, linux-raid@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Shaohua Li , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-raid.ids On Thu, 2016-09-29 at 13:45 +0200, Paul Bolle wrote: > On Thu, 2016-09-29 at 13:12 +0200, Paul Bolle wrote: > > Or did I misread that test? > I finally did some digging: commit e367455a9f25 ("checkpatch: emit > fewer kmalloc_array/kcalloc conversion warnings") shows I didn't. You still misread it a little. I think it's fine as-is. $Constant there is any number and the match regex is any upper case variable.