From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH 37/54] md/raid5: Replace a seq_printf() call by seq_puts() in raid5_status() Date: Thu, 06 Oct 2016 10:36:43 -0700 Message-ID: <1475775403.1914.13.camel@perches.com> References: <566ABCD9.1060404@users.sourceforge.net> <786843ef-4b6f-eb04-7326-2f6f5b408826@users.sourceforge.net> <92c52f1d-d151-cea6-e9ac-31378e6862d0@users.sourceforge.net> <1475771699.1914.10.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: SF Markus Elfring Cc: linux-raid@vger.kernel.org, Christoph Hellwig , Guoqing Jiang , Jens Axboe , Mike Christie , Neil Brown , Shaohua Li , Tomasz Majchrzak , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-raid.ids On Thu, 2016-10-06 at 19:09 +0200, SF Markus Elfring wrote: > > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > > [] > > > @@ -7044,7 +7044,7 @@ static void raid5_status(struct seq_file *seq, struct mddev *mddev) > > >   rdev && test_bit(In_sync, &rdev->flags) ? "U" : "_"); > > >   } > > >   rcu_read_unlock(); > > > - seq_printf (seq, "]"); > > > + seq_puts(seq, "]"); > > seq_putc > How do you think about the possibility that the script "checkpatch.pl" can also point > such a source code transformation out directly? Why don't _you_ try to implement that in checkpatch instead?