From: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
To: linux-raid@vger.kernel.org
Cc: Jes.Sorensen@redhat.com, tomasz.majchrzak@intel.com,
aleksey.obitotskiy@intel.com, pawel.baldysiak@intel.com,
artur.paszkiewicz@intel.com, maksymilian.kunt@intel.com,
Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Subject: [PATCH] imsm: block chunk size change for RAID 10
Date: Wed, 12 Oct 2016 14:28:42 +0200 [thread overview]
Message-ID: <1476275322-1251-1-git-send-email-mariusz.dabrowski@intel.com> (raw)
Chunk size change of RAID 10 array fails because it is not supported but
invalid values still are being written to metadata and array cannot be
assembled after stop. Operation should be blocked before metadata update.
Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
---
super-intel.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 92817e9..0b3b2b1 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -10074,10 +10074,16 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
}
if ((geo->chunksize > 0) && (geo->chunksize != UnSet)
- && (geo->chunksize != info.array.chunk_size))
+ && (geo->chunksize != info.array.chunk_size)) {
+ if (info.array.level == 10) {
+ pr_err("Error. Chunk size change for RAID 10 is not supported.\n");
+ change = -1;
+ goto analyse_change_exit;
+ }
change = CH_MIGRATION;
- else
+ } else {
geo->chunksize = info.array.chunk_size;
+ }
chunk = geo->chunksize / 1024;
--
1.8.3.1
next reply other threads:[~2016-10-12 12:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 12:28 Mariusz Dabrowski [this message]
2016-10-19 15:23 ` [PATCH] imsm: block chunk size change for RAID 10 Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476275322-1251-1-git-send-email-mariusz.dabrowski@intel.com \
--to=mariusz.dabrowski@intel.com \
--cc=Jes.Sorensen@redhat.com \
--cc=aleksey.obitotskiy@intel.com \
--cc=artur.paszkiewicz@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=maksymilian.kunt@intel.com \
--cc=pawel.baldysiak@intel.com \
--cc=tomasz.majchrzak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).