linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pawel Baldysiak <pawel.baldysiak@intel.com>
To: jes.sorensen@redhat.com
Cc: linux-raid@vger.kernel.org, Pawel Baldysiak <pawel.baldysiak@intel.com>
Subject: [PATCH] IMSM: Do not update metadata if not able to migrate
Date: Fri, 21 Oct 2016 11:37:49 +0200	[thread overview]
Message-ID: <1477042671-12934-2-git-send-email-pawel.baldysiak@intel.com> (raw)
In-Reply-To: <1477042671-12934-1-git-send-email-pawel.baldysiak@intel.com>

This patch prevents mdadm from updating metadata if migration is
not possible. The same check is done in analyse_change(),
but in that place - metadata is already modified.

Signed-off-by: Pawel Baldysiak <pawel.baldysiak@intel.com>
---
 super-intel.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/super-intel.c b/super-intel.c
index 6fc9cb1..5c6ab05 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -10067,6 +10067,11 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
 			pr_err("Error. Chunk size change for RAID 10 is not supported.\n");
 			change = -1;
 			goto analyse_change_exit;
+		} else if (info.component_size % (geo->chunksize/512)) {
+			pr_err("New chunk size (%dK) does not evenly divide device size (%lluk). Aborting...\n",
+			       geo->chunksize/1024, info.component_size/2);
+			change = -1;
+			goto analyse_change_exit;
 		}
 		change = CH_MIGRATION;
 	} else {
-- 
2.7.4


  reply	other threads:[~2016-10-21  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  9:37 [PATCH] IMSM: Add warning message when x8-type device is used Pawel Baldysiak
2016-10-21  9:37 ` Pawel Baldysiak [this message]
2016-10-21  9:37 ` [PATCH] IMSM: Enable spanning between VMD domains Pawel Baldysiak
2016-10-26 16:03   ` Jes Sorensen
2016-10-21  9:37 ` [PATCH] Lib.c: Fix geting devname for devices with long path Pawel Baldysiak
2016-10-26 16:03   ` Jes Sorensen
2016-10-21 12:47 ` [PATCH] IMSM: Add warning message when x8-type device is used Jes Sorensen
2016-10-21 14:17   ` Baldysiak, Pawel
2016-10-21 14:22     ` Jes Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477042671-12934-2-git-send-email-pawel.baldysiak@intel.com \
    --to=pawel.baldysiak@intel.com \
    --cc=jes.sorensen@redhat.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).