linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] raid5: revert commit 11367799f3d1
@ 2016-10-26  7:20 Tomasz Majchrzak
  2016-10-27 22:05 ` Shaohua Li
  0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Majchrzak @ 2016-10-26  7:20 UTC (permalink / raw)
  To: linux-raid; +Cc: shli, Tomasz Majchrzak

Revert commit 11367799f3d1 ("md: Prevent IO hold during accessing to faulty
raid5 array") as it doesn't comply with commit c3cce6cda162 ("md/raid5:
ensure device failure recorded before write request returns."). That change
is not required anymore as the problem is resolved by commit 16f889499a52
("md: report 'write_pending' state when array in sync") - read request is
stuck as array state is not reported correctly via sysfs attribute.

Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>
---
 drivers/md/raid5.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

v2:
	The previous patch was corrupted and didn't compile

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index f94472d..323d3c7 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4645,9 +4645,7 @@ finish:
 	}
 
 	if (!bio_list_empty(&s.return_bi)) {
-		if (test_bit(MD_CHANGE_PENDING, &conf->mddev->flags) &&
-				(s.failed <= conf->max_degraded ||
-					conf->mddev->external == 0)) {
+		if (test_bit(MD_CHANGE_PENDING, &conf->mddev->flags)) {
 			spin_lock_irq(&conf->device_lock);
 			bio_list_merge(&conf->return_bi, &s.return_bi);
 			spin_unlock_irq(&conf->device_lock);
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] raid5: revert commit 11367799f3d1
  2016-10-26  7:20 [PATCH v2] raid5: revert commit 11367799f3d1 Tomasz Majchrzak
@ 2016-10-27 22:05 ` Shaohua Li
  0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2016-10-27 22:05 UTC (permalink / raw)
  To: Tomasz Majchrzak; +Cc: linux-raid

On Wed, Oct 26, 2016 at 09:20:39AM +0200, Tomasz Majchrzak wrote:
> Revert commit 11367799f3d1 ("md: Prevent IO hold during accessing to faulty
> raid5 array") as it doesn't comply with commit c3cce6cda162 ("md/raid5:
> ensure device failure recorded before write request returns."). That change
> is not required anymore as the problem is resolved by commit 16f889499a52
> ("md: report 'write_pending' state when array in sync") - read request is
> stuck as array state is not reported correctly via sysfs attribute.
> 
> Signed-off-by: Tomasz Majchrzak <tomasz.majchrzak@intel.com>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-27 22:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26  7:20 [PATCH v2] raid5: revert commit 11367799f3d1 Tomasz Majchrzak
2016-10-27 22:05 ` Shaohua Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).