From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [dm-devel] split scsi passthrough fields out of struct request V2 Date: Tue, 31 Jan 2017 21:35:08 +0000 Message-ID: <1485898487.3113.7.camel@sandisk.com> References: <1485365126-23210-1-git-send-email-hch@lst.de> <1485456745.2540.9.camel@sandisk.com> <20170126185924.GA25289@lst.de> <71e22257-0592-fdd3-25e5-a78ceced2ab9@sandisk.com> <4054e944-b28d-1cd6-574f-6cd90e28c301@fb.com> <1485464486.2540.12.camel@sandisk.com> <6995c991-65a4-8dca-c36e-fb2eff277ca9@fb.com> <1485467235.2540.14.camel@sandisk.com> <1485472465.2540.19.camel@sandisk.com> <1485474426.2540.25.camel@sandisk.com> <1485477510.2540.27.camel@sandisk.com> <2d971693-b79d-c1b9-fb2a-f5dd04128c68@fb.com> <1485479738.2540.30.camel@sandisk.com> <37ab009a-bc2d-d2ae-a875-269ab563a430@fb.com> <9cbf0ce5-ed79-0252-fd2d-34bebaafffa3@fb.com> <1485535925.4267.1.camel@sandisk.com> <2c696943-2a44-4f36-f0f8-0bebceb95a4a@fb.com> <1485825148.2669.18.camel@sandisk.com> <4D024E85-CDE7-4FB0-B8CA-F2B8C86CCFCB@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4D024E85-CDE7-4FB0-B8CA-F2B8C86CCFCB@kernel.dk> Content-Language: en-US Content-ID: Sender: linux-scsi-owner@vger.kernel.org To: "axboe@kernel.dk" Cc: "linux-block@vger.kernel.org" , "linux-raid@vger.kernel.org" , "snitzer@redhat.com" , "hch@lst.de" , "linux-scsi@vger.kernel.org" , "axboe@fb.com" , "j-nomura@ce.jp.nec.com" , "dm-devel@redhat.com" List-Id: linux-raid.ids On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: > That's a known bug in mainline. Pull it into 4.10-rc6, > or use my for-next where everything is already merged.=20 Hello Jens, With your for-next branch (commit c2e60b3a2602) I haven't hit any block layer crashes so far. The only issue I encountered that is new is a memory leak triggered by the SG-IO code. These memory leak reports started to appear after I started testing the mq-deadline scheduler. kmemleak reported the following call stack multiple times after my tests had finished: unreferenced object 0xffff88041119e528 (size 192): =A0 comm "multipathd", pid 2353, jiffies 4295128020 (age 1332.440s) =A0 hex dump (first 32 bytes): =A0=A0=A0=A000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00=A0=A0..........= ...... =A0=A0=A0=A000 00 00 00 00 00 00 00 12 01 00 00 00 00 00 00=A0=A0..........= ...... =A0 backtrace: =A0=A0=A0=A0[] kmemleak_alloc+0x45/0xa0 =A0=A0=A0=A0[] __kmalloc+0x15d/0x2f0 =A0=A0=A0=A0[] bio_alloc_bioset+0x185/0x1f0 =A0=A0=A0=A0[] bio_map_user_iov+0x124/0x400 =A0=A0=A0=A0[] blk_rq_map_user_iov+0x11a/0x210 =A0=A0=A0=A0[] blk_rq_map_user+0x4d/0x60 =A0=A0=A0=A0[] sg_io+0x3d4/0x410 =A0=A0=A0=A0[] scsi_cmd_ioctl+0x300/0x490 =A0=A0=A0=A0[] scsi_cmd_blk_ioctl+0x3d/0x50 =A0=A0=A0=A0[] sd_ioctl+0x80/0x100 =A0=A0=A0=A0[] blkdev_ioctl+0x51e/0x9f0 =A0=A0=A0=A0[] block_ioctl+0x38/0x40 =A0=A0=A0=A0[] do_vfs_ioctl+0x8f/0x700 =A0=A0=A0=A0[] SyS_ioctl+0x3c/0x70 =A0=A0=A0=A0[] entry_SYSCALL_64_fastpath+0x18/0xad Bart.=