From: Ming Lei <tom.leiming@gmail.com>
To: Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>, NeilBrown <neilb@suse.com>
Cc: Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH v1 3/5] md: fail if mddev->bio_set can't be created
Date: Fri, 10 Feb 2017 18:56:15 +0800 [thread overview]
Message-ID: <1486724177-14817-4-git-send-email-tom.leiming@gmail.com> (raw)
In-Reply-To: <1486724177-14817-1-git-send-email-tom.leiming@gmail.com>
The current behaviour is to fall back to allocate
bio from 'fs_bio_set', that isn't a correct way
because it might cause deadlock.
So this patch simply return failure if mddev->bio_set
can't be created.
Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
drivers/md/md.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 4c1b82defa78..3425c2b779a6 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5270,8 +5270,11 @@ int md_run(struct mddev *mddev)
sysfs_notify_dirent_safe(rdev->sysfs_state);
}
- if (mddev->bio_set == NULL)
+ if (mddev->bio_set == NULL) {
mddev->bio_set = bioset_create(BIO_POOL_SIZE, 0);
+ if (!mddev->bio_set)
+ return -ENOMEM;
+ }
spin_lock(&pers_lock);
pers = find_pers(mddev->level, mddev->clevel);
--
2.7.4
next prev parent reply other threads:[~2017-02-10 10:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 10:56 [PATCH v1 0/5] md: use bio_clone_fast() Ming Lei
2017-02-10 10:56 ` [PATCH v1 1/5] block: introduce bio_clone_bioset_partial() Ming Lei
2017-02-13 13:46 ` Christoph Hellwig
2017-02-14 1:04 ` Ming Lei
2017-02-14 16:01 ` Christoph Hellwig
2017-02-15 2:26 ` Ming Lei
2017-02-10 10:56 ` [PATCH v1 2/5] md/raid1: use bio_clone_bioset_partial() in case of write behind Ming Lei
2017-02-13 13:48 ` Christoph Hellwig
2017-02-10 10:56 ` Ming Lei [this message]
2017-02-13 13:45 ` [PATCH v1 3/5] md: fail if mddev->bio_set can't be created Christoph Hellwig
2017-02-10 10:56 ` [PATCH v1 4/5] md: remove unnecessary check on mddev Ming Lei
2017-02-13 13:49 ` Christoph Hellwig
2017-02-10 10:56 ` [PATCH v1 5/5] md: fast clone bio in bio_clone_mddev() Ming Lei
2017-02-13 13:49 ` Christoph Hellwig
2017-02-11 0:38 ` [PATCH v1 0/5] md: use bio_clone_fast() Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486724177-14817-4-git-send-email-tom.leiming@gmail.com \
--to=tom.leiming@gmail.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).