linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Shaohua Li <shli@kernel.org>, Jens Axboe <axboe@fb.com>,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Ming Lei <tom.leiming@gmail.com>
Subject: [PATCH v1 05/14] md: prepare for managing resync I/O pages in clean way
Date: Fri, 24 Feb 2017 23:42:42 +0800	[thread overview]
Message-ID: <1487950971-1131-6-git-send-email-tom.leiming@gmail.com> (raw)
In-Reply-To: <1487950971-1131-1-git-send-email-tom.leiming@gmail.com>

Now resync I/O use bio's bec table to manage pages,
this way is very hacky, and may not work any more
once multipage bvec is introduced.

So introduce helpers and new data structure for
managing resync I/O pages more cleanly.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
---
 drivers/md/md.h | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/drivers/md/md.h b/drivers/md/md.h
index 1d63239a1be4..df18ae05838d 100644
--- a/drivers/md/md.h
+++ b/drivers/md/md.h
@@ -720,4 +720,65 @@ static inline void mddev_check_writesame(struct mddev *mddev, struct bio *bio)
 #define RESYNC_BLOCK_SIZE (64*1024)
 #define RESYNC_PAGES ((RESYNC_BLOCK_SIZE + PAGE_SIZE-1) / PAGE_SIZE)
 
+/* for managing resync I/O pages */
+struct resync_pages {
+	unsigned	idx;	/* for get/put page from the pool */
+	void		*raid_bio;
+	struct page	*pages[RESYNC_PAGES];
+};
+
+static inline int resync_alloc_pages(struct resync_pages *rp,
+				     gfp_t gfp_flags)
+{
+	int i;
+
+	for (i = 0; i < RESYNC_PAGES; i++) {
+		rp->pages[i] = alloc_page(gfp_flags);
+		if (!rp->pages[i])
+			goto out_free;
+	}
+
+	return 0;
+
+ out_free:
+	while (--i >= 0)
+		__free_page(rp->pages[i]);
+	return -ENOMEM;
+}
+
+static inline void resync_free_pages(struct resync_pages *rp)
+{
+	int i;
+
+	for (i = 0; i < RESYNC_PAGES; i++)
+		__free_page(rp->pages[i]);
+}
+
+static inline void resync_get_all_pages(struct resync_pages *rp)
+{
+	int i;
+
+	for (i = 0; i < RESYNC_PAGES; i++)
+		get_page(rp->pages[i]);
+}
+
+static inline void resync_store_page(struct resync_pages *rp, struct page *page)
+{
+	if (WARN_ON(!rp->idx))
+		return;
+	rp->pages[--rp->idx] = page;
+}
+
+static inline struct page *resync_fetch_page(struct resync_pages *rp)
+{
+	if (WARN_ON_ONCE(rp->idx >= RESYNC_PAGES))
+		return NULL;
+	return rp->pages[rp->idx++];
+}
+
+static inline bool resync_page_available(struct resync_pages *rp)
+{
+	return rp->idx < RESYNC_PAGES;
+}
+
 #endif /* _MD_MD_H */
-- 
2.7.4

  parent reply	other threads:[~2017-02-24 15:42 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-24 15:42 [PATCH v1 00/14] md: cleanup on direct access to bvec table Ming Lei
2017-02-24 15:42 ` [PATCH v1 01/14] block: introduce bio_segments_all() Ming Lei
2017-02-25 18:22   ` Christoph Hellwig
2017-02-28 12:15     ` Ming Lei
2017-02-24 15:42 ` [PATCH v1 02/14] block: introduce bio_remove_last_page() Ming Lei
2017-02-25 18:23   ` Christoph Hellwig
2017-02-28 12:18     ` Ming Lei
2017-02-24 15:42 ` [PATCH v1 03/14] md: raid1/raid10: use bio_remove_last_page() Ming Lei
2017-02-24 15:42 ` [PATCH v1 04/14] md: move two macros into md.h Ming Lei
2017-02-24 15:42 ` Ming Lei [this message]
2017-02-24 15:42 ` [PATCH v1 06/14] md: raid1: simplify r1buf_pool_free() Ming Lei
2017-02-24 15:42 ` [PATCH v1 07/14] md: raid1: don't use bio's vec table to manage resync pages Ming Lei
2017-02-24 15:42 ` [PATCH v1 08/14] md: raid1: retrieve page from pre-allocated resync page array Ming Lei
2017-02-24 15:42 ` [PATCH v1 09/14] md: raid1: use bio helper in process_checks() Ming Lei
2017-02-24 15:42 ` [PATCH v1 10/14] md: raid1: use bio_segments_all() Ming Lei
2017-02-24 15:42 ` [PATCH v1 11/14] md: raid10: refactor code of read reshape's .bi_end_io Ming Lei
2017-02-24 15:42 ` [PATCH v1 12/14] md: raid10: don't use bio's vec table to manage resync pages Ming Lei
2017-02-24 15:42 ` [PATCH v1 13/14] md: raid10: retrieve page from preallocated resync page array Ming Lei
2017-02-24 15:42 ` [PATCH v1 14/14] md: raid10: avoid direct access to bvec table in handle_reshape_read_error Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487950971-1131-6-git-send-email-tom.leiming@gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).