[PATCH] md:fix a trivial typo in comments

[PATCH] md:fix a trivial typo in comments

[Zhilong Liu]

fix a trivial typo in freeze_array() of raid1.c

Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
 drivers/md/raid1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 7b0f647..2ec0617 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
 static void freeze_array(struct r1conf *conf, int extra)
 {
 	/* stop syncio and normal IO and wait for everything to
-	 * go quite.
+	 * go quit.
 	 * We wait until nr_pending match nr_queued+extra
 	 * This is called in the context of one normal IO request
 	 * that has failed. Thus any sync request that might be pending
-- 
2.6.6

Re: [PATCH] md:fix a trivial typo in comments

[Jack Wang]

2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
> fix a trivial typo in freeze_array() of raid1.c
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
>  static void freeze_array(struct r1conf *conf, int extra)
>  {
>         /* stop syncio and normal IO and wait for everything to
> -        * go quite.
> +        * go quit.
>          * We wait until nr_pending match nr_queued+extra
>          * This is called in the context of one normal IO request
>          * that has failed. Thus any sync request that might be pending
> --

s/quite/quietly ?

Cheers,
Jack

> 2.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] md:fix a trivial typo in comments

[Guoqing Jiang]

On 03/13/2017 05:10 PM, Jack Wang wrote:
> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>> fix a trivial typo in freeze_array() of raid1.c
>>
>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>> ---
>>   drivers/md/raid1.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>> index 7b0f647..2ec0617 100644
>> --- a/drivers/md/raid1.c
>> +++ b/drivers/md/raid1.c
>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
>>   static void freeze_array(struct r1conf *conf, int extra)
>>   {
>>          /* stop syncio and normal IO and wait for everything to
>> -        * go quite.
>> +        * go quit.
>>           * We wait until nr_pending match nr_queued+extra
>>           * This is called in the context of one normal IO request
>>           * that has failed. Thus any sync request that might be pending
>> --
> s/quite/quietly ?

I guess it should be "quiet" if referring from freeze_array in raid10.c.

Thanks,
Guoqing

Re: [PATCH] md:fix a trivial typo in comments

[zhilong]

On 03/13/2017 05:23 PM, Guoqing Jiang wrote:
>
>
> On 03/13/2017 05:10 PM, Jack Wang wrote:
>> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>>> fix a trivial typo in freeze_array() of raid1.c
>>>
>>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>>> ---
>>>   drivers/md/raid1.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>>> index 7b0f647..2ec0617 100644
>>> --- a/drivers/md/raid1.c
>>> +++ b/drivers/md/raid1.c
>>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, 
>>> sector_t start_next_window,
>>>   static void freeze_array(struct r1conf *conf, int extra)
>>>   {
>>>          /* stop syncio and normal IO and wait for everything to
>>> -        * go quite.
>>> +        * go quit.
>>>           * We wait until nr_pending match nr_queued+extra
>>>           * This is called in the context of one normal IO request
>>>           * that has failed. Thus any sync request that might be 
>>> pending
>>> -- 
>> s/quite/quietly ?
>
> I guess it should be "quiet" if referring from freeze_array in raid10.c.

many thanks for your review and correction. and here keep 'quiet' same 
as raid10.c?

Thanks,
-Zhilong

>
> Thanks,
> Guoqing
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH] md:fix a trivial typo in comments

[John Stoffel]

>>>>> "Zhilong" == Zhilong Liu <zlliu@suse.com> writes:

Zhilong> fix a trivial typo in freeze_array() of raid1.c
Zhilong> Signed-off-by: Zhilong Liu <zlliu@suse.com>
Zhilong> ---
Zhilong>  drivers/md/raid1.c | 2 +-
Zhilong>  1 file changed, 1 insertion(+), 1 deletion(-)

Zhilong> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
Zhilong> index 7b0f647..2ec0617 100644
Zhilong> --- a/drivers/md/raid1.c
Zhilong> +++ b/drivers/md/raid1.c
Zhilong> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
Zhilong>  static void freeze_array(struct r1conf *conf, int extra)
Zhilong>  {
Zhilong>  	/* stop syncio and normal IO and wait for everything to
Zhilong> -	 * go quite.
Zhilong> +	 * go quit.
Zhilong>  	 * We wait until nr_pending match nr_queued+extra
Zhilong>  	 * This is called in the context of one normal IO request
Zhilong>  	 * that has failed. Thus any sync request that might be pending
Zhilong> -- 
Zhilong> 2.6.6

Don't you mean "quiet" instead?

John

Re: [PATCH] md:fix a trivial typo in comments

[Coly Li]

On 2017/3/13 下午1:53, Zhilong Liu wrote:
> fix a trivial typo in freeze_array() of raid1.c
> 
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
>  static void freeze_array(struct r1conf *conf, int extra)
>  {
>  	/* stop syncio and normal IO and wait for everything to
> -	 * go quite.

	It should be "quiet"， this is a typo， thanks for catching it :-)

Coly

[PATCH v1] md:fix a trivial typo in comments

[Zhilong Liu]

raid1.c: fix a trivial typo in comments of freeze_array().

Cc: Jack Wang <jack.wang.usish@gmail.com>
Cc: Guoqing Jiang <gqjiang@suse.com>
Cc: John Stoffel <john@stoffel.org>
Cc: Coly Li <colyli@suse.de>
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
 drivers/md/raid1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index fbc2d78..92ca6de 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
 static void freeze_array(struct r1conf *conf, int extra)
 {
 	/* Stop sync I/O and normal I/O and wait for everything to
-	 * go quite.
+	 * go quiet.
 	 * This is called in two situations:
 	 * 1) management command handlers (reshape, remove disk, quiesce).
 	 * 2) one normal I/O request failed.
-- 
2.6.6

Re: [PATCH v1] md:fix a trivial typo in comments

[Coly Li]

On 2017/3/14 下午3:52, Zhilong Liu wrote:
> raid1.c: fix a trivial typo in comments of freeze_array().
> 
> Cc: Jack Wang <jack.wang.usish@gmail.com>
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: John Stoffel <john@stoffel.org>
> Cc: Coly Li <colyli@suse.de>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>

Acked-by: Coly Li <colyli@suse.de>

> ---
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index fbc2d78..92ca6de 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
>  static void freeze_array(struct r1conf *conf, int extra)
>  {
>  	/* Stop sync I/O and normal I/O and wait for everything to
> -	 * go quite.
> +	 * go quiet.
>  	 * This is called in two situations:
>  	 * 1) management command handlers (reshape, remove disk, quiesce).
>  	 * 2) one normal I/O request failed.
> 

Re: [PATCH v1] md:fix a trivial typo in comments

[Shaohua Li]

On Tue, Mar 14, 2017 at 03:52:26PM +0800, Zhilong Liu wrote:
> raid1.c: fix a trivial typo in comments of freeze_array().
> 
> Cc: Jack Wang <jack.wang.usish@gmail.com>
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: John Stoffel <john@stoffel.org>
> Cc: Coly Li <colyli@suse.de>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>

applied, thanks

> ---
>  drivers/md/raid1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index fbc2d78..92ca6de 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
>  static void freeze_array(struct r1conf *conf, int extra)
>  {
>  	/* Stop sync I/O and normal I/O and wait for everything to
> -	 * go quite.
> +	 * go quiet.
>  	 * This is called in two situations:
>  	 * 1) management command handlers (reshape, remove disk, quiesce).
>  	 * 2) one normal I/O request failed.
> -- 
> 2.6.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html