* [PATCH] md:fix a trivial typo in comments
@ 2017-03-15 8:14 Zhilong Liu
2017-03-16 4:26 ` [PATCH] md/bitmap:fix a typo in comments of bitmap_read_sb Zhilong Liu
0 siblings, 1 reply; 9+ messages in thread
From: Zhilong Liu @ 2017-03-15 8:14 UTC (permalink / raw)
To: shli; +Cc: linux-raid, Zhilong Liu
bitmap.c: fix a trivial typo in comments of bitmap_read_sb().
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
drivers/md/bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 9fb2cca..af9e0f0 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -696,7 +696,7 @@ static int bitmap_read_sb(struct bitmap *bitmap)
out:
kunmap_atomic(sb);
- /* Assiging chunksize is required for "re_read" */
+ /* Assigning chunksize is required for "re_read" */
bitmap->mddev->bitmap_info.chunksize = chunksize;
if (err == 0 && nodes && (bitmap->cluster_slot < 0)) {
err = md_setup_cluster(bitmap->mddev, nodes);
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] md/bitmap:fix a typo in comments of bitmap_read_sb
2017-03-15 8:14 [PATCH] md:fix a trivial typo in comments Zhilong Liu
@ 2017-03-16 4:26 ` Zhilong Liu
0 siblings, 0 replies; 9+ messages in thread
From: Zhilong Liu @ 2017-03-16 4:26 UTC (permalink / raw)
To: shli; +Cc: linux-raid, Zhilong Liu
bitmap.c: fix a trivial typo in comments of bitmap_read_sb().
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
drivers/md/bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
index 9fb2cca..af9e0f0 100644
--- a/drivers/md/bitmap.c
+++ b/drivers/md/bitmap.c
@@ -696,7 +696,7 @@ static int bitmap_read_sb(struct bitmap *bitmap)
out:
kunmap_atomic(sb);
- /* Assiging chunksize is required for "re_read" */
+ /* Assigning chunksize is required for "re_read" */
bitmap->mddev->bitmap_info.chunksize = chunksize;
if (err == 0 && nodes && (bitmap->cluster_slot < 0)) {
err = md_setup_cluster(bitmap->mddev, nodes);
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] md:fix a trivial typo in comments
@ 2017-03-13 5:53 Zhilong Liu
2017-03-13 9:10 ` Jack Wang
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Zhilong Liu @ 2017-03-13 5:53 UTC (permalink / raw)
To: shli; +Cc: linux-raid, Zhilong Liu
fix a trivial typo in freeze_array() of raid1.c
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
drivers/md/raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 7b0f647..2ec0617 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
static void freeze_array(struct r1conf *conf, int extra)
{
/* stop syncio and normal IO and wait for everything to
- * go quite.
+ * go quit.
* We wait until nr_pending match nr_queued+extra
* This is called in the context of one normal IO request
* that has failed. Thus any sync request that might be pending
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
@ 2017-03-13 9:10 ` Jack Wang
2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 14:27 ` John Stoffel
2017-03-13 14:59 ` Coly Li
2 siblings, 1 reply; 9+ messages in thread
From: Jack Wang @ 2017-03-13 9:10 UTC (permalink / raw)
To: Zhilong Liu; +Cc: shli, linux-raid
2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
> fix a trivial typo in freeze_array() of raid1.c
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* stop syncio and normal IO and wait for everything to
> - * go quite.
> + * go quit.
> * We wait until nr_pending match nr_queued+extra
> * This is called in the context of one normal IO request
> * that has failed. Thus any sync request that might be pending
> --
s/quite/quietly ?
Cheers,
Jack
> 2.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 9:10 ` Jack Wang
@ 2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 9:26 ` zhilong
0 siblings, 1 reply; 9+ messages in thread
From: Guoqing Jiang @ 2017-03-13 9:23 UTC (permalink / raw)
To: Jack Wang, Zhilong Liu; +Cc: shli, linux-raid
On 03/13/2017 05:10 PM, Jack Wang wrote:
> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>> fix a trivial typo in freeze_array() of raid1.c
>>
>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>> ---
>> drivers/md/raid1.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>> index 7b0f647..2ec0617 100644
>> --- a/drivers/md/raid1.c
>> +++ b/drivers/md/raid1.c
>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
>> static void freeze_array(struct r1conf *conf, int extra)
>> {
>> /* stop syncio and normal IO and wait for everything to
>> - * go quite.
>> + * go quit.
>> * We wait until nr_pending match nr_queued+extra
>> * This is called in the context of one normal IO request
>> * that has failed. Thus any sync request that might be pending
>> --
> s/quite/quietly ?
I guess it should be "quiet" if referring from freeze_array in raid10.c.
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 9:23 ` Guoqing Jiang
@ 2017-03-13 9:26 ` zhilong
0 siblings, 0 replies; 9+ messages in thread
From: zhilong @ 2017-03-13 9:26 UTC (permalink / raw)
To: Guoqing Jiang, Jack Wang; +Cc: shli, linux-raid
On 03/13/2017 05:23 PM, Guoqing Jiang wrote:
>
>
> On 03/13/2017 05:10 PM, Jack Wang wrote:
>> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>>> fix a trivial typo in freeze_array() of raid1.c
>>>
>>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>>> ---
>>> drivers/md/raid1.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>>> index 7b0f647..2ec0617 100644
>>> --- a/drivers/md/raid1.c
>>> +++ b/drivers/md/raid1.c
>>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf,
>>> sector_t start_next_window,
>>> static void freeze_array(struct r1conf *conf, int extra)
>>> {
>>> /* stop syncio and normal IO and wait for everything to
>>> - * go quite.
>>> + * go quit.
>>> * We wait until nr_pending match nr_queued+extra
>>> * This is called in the context of one normal IO request
>>> * that has failed. Thus any sync request that might be
>>> pending
>>> --
>> s/quite/quietly ?
>
> I guess it should be "quiet" if referring from freeze_array in raid10.c.
many thanks for your review and correction. and here keep 'quiet' same
as raid10.c?
Thanks,
-Zhilong
>
> Thanks,
> Guoqing
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
@ 2017-03-13 14:27 ` John Stoffel
2017-03-13 14:59 ` Coly Li
2 siblings, 0 replies; 9+ messages in thread
From: John Stoffel @ 2017-03-13 14:27 UTC (permalink / raw)
To: Zhilong Liu; +Cc: shli, linux-raid
>>>>> "Zhilong" == Zhilong Liu <zlliu@suse.com> writes:
Zhilong> fix a trivial typo in freeze_array() of raid1.c
Zhilong> Signed-off-by: Zhilong Liu <zlliu@suse.com>
Zhilong> ---
Zhilong> drivers/md/raid1.c | 2 +-
Zhilong> 1 file changed, 1 insertion(+), 1 deletion(-)
Zhilong> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
Zhilong> index 7b0f647..2ec0617 100644
Zhilong> --- a/drivers/md/raid1.c
Zhilong> +++ b/drivers/md/raid1.c
Zhilong> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
Zhilong> static void freeze_array(struct r1conf *conf, int extra)
Zhilong> {
Zhilong> /* stop syncio and normal IO and wait for everything to
Zhilong> - * go quite.
Zhilong> + * go quit.
Zhilong> * We wait until nr_pending match nr_queued+extra
Zhilong> * This is called in the context of one normal IO request
Zhilong> * that has failed. Thus any sync request that might be pending
Zhilong> --
Zhilong> 2.6.6
Don't you mean "quiet" instead?
John
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
2017-03-13 14:27 ` John Stoffel
@ 2017-03-13 14:59 ` Coly Li
2 siblings, 0 replies; 9+ messages in thread
From: Coly Li @ 2017-03-13 14:59 UTC (permalink / raw)
To: Zhilong Liu, shli; +Cc: linux-raid
On 2017/3/13 下午1:53, Zhilong Liu wrote:
> fix a trivial typo in freeze_array() of raid1.c
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* stop syncio and normal IO and wait for everything to
> - * go quite.
It should be "quiet"， this is a typo， thanks for catching it :-)
Coly
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] md: fix a trivial typo in comments
@ 2016-03-21 11:19 Wei Fang
0 siblings, 0 replies; 9+ messages in thread
From: Wei Fang @ 2016-03-21 11:19 UTC (permalink / raw)
To: shli; +Cc: linux-raid, Wei Fang
Fix a trivial typo in md_ioctl().
Signed-off-by: Wei Fang <fangwei1@huawei.com>
---
drivers/md/md.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index e55e6cf..9804355 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6883,7 +6883,7 @@ static int md_ioctl(struct block_device *bdev, fmode_t mode,
case ADD_NEW_DISK:
/* We can support ADD_NEW_DISK on read-only arrays
- * on if we are re-adding a preexisting device.
+ * only if we are re-adding a preexisting device.
* So require mddev->pers and MD_DISK_SYNC.
*/
if (mddev->pers) {
--
1.7.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-03-16 4:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 8:14 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-16 4:26 ` [PATCH] md/bitmap:fix a typo in comments of bitmap_read_sb Zhilong Liu
-- strict thread matches above, loose matches on Subject: below --
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 9:26 ` zhilong
2017-03-13 14:27 ` John Stoffel
2017-03-13 14:59 ` Coly Li
2016-03-21 11:19 [PATCH] md: fix " Wei Fang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).