linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Ni <xni@redhat.com>
To: jes.sorensen@gmail.com
Cc: ncroxon@redhat.com, artur.paszkiewicz@intel.com,
	linux-raid@vger.kernel.org
Subject: [PATCH 2/2] mdadm: Forced type conversion to avoid truncation
Date: Sat, 18 Mar 2017 10:33:45 +0800	[thread overview]
Message-ID: <1489804425-4949-2-git-send-email-xni@redhat.com> (raw)
In-Reply-To: <1489804425-4949-1-git-send-email-xni@redhat.com>

Gcc reports it needs 19 bytes to right to disk->serial. Because the type of argument i
is int. But the meaning of i is failed disk number. So it doesn't need to use 19 bytes.
Just add a type conversion to avoid this building error

Signed-off-by: Xiao Ni <xni@redhat.com>
---
 super-intel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/super-intel.c b/super-intel.c
index 343f20d..e1618f1 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5228,7 +5228,7 @@ static int init_super_imsm_volume(struct supertype *st, mdu_array_info_t *info,
 			disk->status = CONFIGURED_DISK | FAILED_DISK;
 			disk->scsi_id = __cpu_to_le32(~(__u32)0);
 			snprintf((char *) disk->serial, MAX_RAID_SERIAL_LEN,
-				 "missing:%d", i);
+				 "missing:%d", (__u8)i);
 		}
 		find_missing(super);
 	} else {
-- 
2.7.4


  reply	other threads:[~2017-03-18  2:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-18  2:33 [PATCH 1/2] Replace snprintf with strncpy at some places to avoid truncation Xiao Ni
2017-03-18  2:33 ` Xiao Ni [this message]
2017-03-28 17:57   ` [PATCH 2/2] mdadm: Forced type conversion " jes.sorensen
2017-03-28 17:55 ` [PATCH 1/2] Replace snprintf with strncpy at some places " jes.sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1489804425-4949-2-git-send-email-xni@redhat.com \
    --to=xni@redhat.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=jes.sorensen@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=ncroxon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).