* [PATCH] mdadm:it doesn't make sense to set --bitmap twice
@ 2017-03-20 5:21 Zhilong Liu
2017-03-27 22:14 ` jes.sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Zhilong Liu @ 2017-03-20 5:21 UTC (permalink / raw)
To: jes.sorensen; +Cc: linux-raid, Zhilong Liu
mdadm.c: it doesn't make sense to set --bitmap twice.
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
mdadm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mdadm.c b/mdadm.c
index 566051f..2d8498f 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1145,6 +1145,10 @@ int main(int argc, char *argv[])
case O(CREATE,Bitmap): /* here we create the bitmap */
case O(GROW,'b'):
case O(GROW,Bitmap):
+ if (s.bitmap_file) {
+ pr_err("bitmap cannot be set twice. Second value: %s.\n", optarg);
+ exit(2);
+ }
if (strcmp(optarg, "internal") == 0 ||
strcmp(optarg, "none") == 0 ||
strchr(optarg, '/') != NULL) {
--
2.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mdadm:it doesn't make sense to set --bitmap twice
2017-03-20 5:21 [PATCH] mdadm:it doesn't make sense to set --bitmap twice Zhilong Liu
@ 2017-03-27 22:14 ` jes.sorensen
0 siblings, 0 replies; 2+ messages in thread
From: jes.sorensen @ 2017-03-27 22:14 UTC (permalink / raw)
To: Zhilong Liu; +Cc: linux-raid
Zhilong Liu <zlliu@suse.com> writes:
> mdadm.c: it doesn't make sense to set --bitmap twice.
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
> mdadm.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-27 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 5:21 [PATCH] mdadm:it doesn't make sense to set --bitmap twice Zhilong Liu
2017-03-27 22:14 ` jes.sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).