linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	Mimi Zohar
	<zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	Amir Goldstein <amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Shaohua Li <shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Steven Whitehouse
	<swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 10/23] afs: switch to use uuid_t and uuid_gen
Date: Thu, 25 May 2017 16:29:21 +0300	[thread overview]
Message-ID: <1495718961.6967.117.camel@linux.intel.com> (raw)
In-Reply-To: <20170525130027.GA30194-jcswGhMUV9g@public.gmane.org>

On Thu, 2017-05-25 at 15:00 +0200, Christoph Hellwig wrote:
> On Tue, May 23, 2017 at 04:11:39PM +0300, Andy Shevchenko wrote:
> > Since we introduced a union it's possible that we might access the
> > member which wasn't last modified one. So, my comment is to give an
> > attention on such possibility and avoid if there is an aliasing
> > happened.
> 
> We do for AFS (and XFS for fs fsid).  My preference would be to
> not have the v1 struct defintion but instead provide a few
> helpers in uuid.h that use get_unaligned_be* if needed:
> 
> 	uuid_v1_time_low()
> 	uuid_v1_time_mid()
> 	uuid_v1_time_time_hi_and_version()..
> 
> From his previously reply it seems like Dave doesn't like that idea
> too much, in which case I suspect moving struct uuid_v1 back into
> afs and living with cast in it is the way to go.

Personally I don't like that union stuff, so, definitely my vote to get
rid of AFS stuff in generic helpers.

OTOH if there will be more users of such API then something like you
proposed would be sufficient without introducing a union.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

  parent reply	other threads:[~2017-05-25 13:29 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18  6:26 cleanup UUID types V3 Christoph Hellwig
2017-05-18  6:26 ` [PATCH 03/23] uuid: remove uuid_be defintions from the uapi header Christoph Hellwig
     [not found]   ` <20170518062705.25902-4-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18  7:12     ` Joe Perches
     [not found]       ` <1495091565.31562.28.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-05-18  7:13         ` Christoph Hellwig
     [not found]       ` <20170518071352.GA515-jcswGhMUV9g@public.gmane.org>
2017-05-19 10:58         ` David Howells
     [not found]           ` <13041.1495191521-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org>
2017-05-21  6:55             ` Christoph Hellwig
2017-05-18  6:26 ` [PATCH 07/23] uuid: hoist helpers uuid_equal() and uuid_copy() from xfs Christoph Hellwig
     [not found] ` <20170518062705.25902-1-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18  6:26   ` [PATCH 01/23] xfs: use uuid_copy() helper to abstract uuid_t Christoph Hellwig
     [not found]     ` <20170518062705.25902-2-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 13:27       ` Brian Foster
2017-05-18 23:32       ` Darrick J. Wong
2017-05-18  6:26   ` [PATCH 02/23] xfs: use uuid_be to implement the uuid_t type Christoph Hellwig
     [not found]     ` <20170518062705.25902-3-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 13:27       ` Brian Foster
2017-05-18 23:34       ` Darrick J. Wong
2017-05-18  6:26   ` [PATCH 04/23] uuid: rename uuid types Christoph Hellwig
     [not found]     ` <20170518062705.25902-5-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 17:42       ` Darrick J. Wong
2017-05-18  6:26   ` [PATCH 05/23] uuid: don't export guid_index and uuid_index Christoph Hellwig
2017-05-18  6:26   ` [PATCH 06/23] uuid: add the v1 layout to uuid_t Christoph Hellwig
2017-05-18  6:26   ` [PATCH 08/23] uuid: hoist uuid_is_null() helper from libnvdimm Christoph Hellwig
2017-05-18  6:26   ` [PATCH 09/23] S390/sysinfo: use uuid_is_null instead of opencoding it Christoph Hellwig
2017-05-18  6:26   ` [PATCH 10/23] afs: switch to use uuid_t and uuid_gen Christoph Hellwig
2017-05-22 18:49     ` Andy Shevchenko
     [not found]       ` <1495478957.6967.69.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-23  8:49         ` Christoph Hellwig
     [not found]           ` <20170523084956.GB20121-jcswGhMUV9g@public.gmane.org>
2017-05-23 13:11             ` Andy Shevchenko
     [not found]               ` <1495545099.6967.81.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-25 13:00                 ` Christoph Hellwig
     [not found]                   ` <20170525130027.GA30194-jcswGhMUV9g@public.gmane.org>
2017-05-25 13:29                     ` Andy Shevchenko [this message]
2017-05-18  6:26   ` [PATCH 11/23] uuid: remove struct uuid_v1 Christoph Hellwig
2017-05-18  6:26   ` [PATCH 12/23] xfs: remove uuid_getnodeuniq and xfs_uu_t Christoph Hellwig
     [not found]     ` <20170518062705.25902-13-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 13:27       ` Brian Foster
2017-05-18 23:35       ` Darrick J. Wong
2017-05-18  6:26   ` [PATCH 13/23] md: namespace private helper names Christoph Hellwig
     [not found]     ` <20170518062705.25902-14-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 18:32       ` Shaohua Li
2017-05-22 18:52       ` Andy Shevchenko
2017-05-23  8:41         ` Christoph Hellwig
2017-05-18  6:26   ` [PATCH 14/23] xfs: use the common helper uuid_is_null() Christoph Hellwig
     [not found]     ` <20170518062705.25902-15-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 13:27       ` Brian Foster
2017-05-18  6:26   ` [PATCH 15/23] block: remove blk_part_pack_uuid Christoph Hellwig
     [not found]     ` <20170518062705.25902-16-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 23:15       ` Mimi Zohar
2017-05-18  6:26   ` [PATCH 16/23] ima/policy: switch to use uuid_t Christoph Hellwig
     [not found]     ` <20170518062705.25902-17-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 23:16       ` Mimi Zohar
2017-05-18  6:26   ` [PATCH 17/23] fs: switch ->s_uuid to uuid_t Christoph Hellwig
     [not found]     ` <20170518062705.25902-18-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18 23:17       ` Mimi Zohar
2017-05-18  6:27   ` [PATCH 18/23] overlayfs: use uuid_t instead of uuid_be Christoph Hellwig
2017-05-18  6:27   ` [PATCH 19/23] partitions/ldm: switch to use uuid_t Christoph Hellwig
2017-05-18  6:27   ` [PATCH 20/23] sysctl: " Christoph Hellwig
2017-05-18  6:27   ` [PATCH 21/23] nvme: switch to uuid_t Christoph Hellwig
2017-05-18  6:27   ` [PATCH 22/23] scsi_debug: " Christoph Hellwig
2017-05-18  6:27   ` [PATCH 23/23] uuid: remove uuid_be Christoph Hellwig
     [not found]     ` <20170518062705.25902-24-hch-jcswGhMUV9g@public.gmane.org>
2017-05-18  7:57       ` Amir Goldstein
     [not found]         ` <CAOQ4uxj+TH5vS5HoEFPJXUpneBqr+YwbVES0bsHzw9qmS8HzKg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-18  8:56           ` Christoph Hellwig
     [not found]             ` <20170518085629.GA6149-jcswGhMUV9g@public.gmane.org>
2017-05-22 18:59               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495718961.6967.117.camel@linux.intel.com \
    --to=andriy.shevchenko-vuqaysv1563yd54fqh9/ca@public.gmane.org \
    --cc=amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=hch-jcswGhMUV9g@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-xfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shli-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=swhiteho-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=zohar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).