* [PATCH v2] Monitor: Include containers in spare migration
@ 2017-08-16 12:59 Mariusz Tkaczyk
2017-08-16 13:06 ` Jes Sorensen
0 siblings, 1 reply; 2+ messages in thread
From: Mariusz Tkaczyk @ 2017-08-16 12:59 UTC (permalink / raw)
To: jes.sorensen; +Cc: linux-raid, Mariusz Tkaczyk
Spare migration doesn't work for external metadata. mdadm skips
a container with spare device because it is inactive. It used to work
because GET_ARRAY_INFO ioctl returned valid structure for a container
and mdadm treated such response as active container. Current
implementation checks it in sysfs where container is shown as inactive.
Adapt sysfs implementation to work the same way as ioctl.
Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
---
Monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Monitor.c b/Monitor.c
index f70e5b5..497e364 100644
--- a/Monitor.c
+++ b/Monitor.c
@@ -497,7 +497,7 @@ static int check_array(struct state *st, struct mdstat_ent *mdstat,
if (mse->level == NULL)
is_container = 1;
- if (!md_array_active(fd))
+ if (!is_container && !md_array_active(fd))
goto disappeared;
fcntl(fd, F_SETFD, FD_CLOEXEC);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] Monitor: Include containers in spare migration
2017-08-16 12:59 [PATCH v2] Monitor: Include containers in spare migration Mariusz Tkaczyk
@ 2017-08-16 13:06 ` Jes Sorensen
0 siblings, 0 replies; 2+ messages in thread
From: Jes Sorensen @ 2017-08-16 13:06 UTC (permalink / raw)
To: Mariusz Tkaczyk; +Cc: linux-raid
On 08/16/2017 08:59 AM, Mariusz Tkaczyk wrote:
> Spare migration doesn't work for external metadata. mdadm skips
> a container with spare device because it is inactive. It used to work
> because GET_ARRAY_INFO ioctl returned valid structure for a container
> and mdadm treated such response as active container. Current
> implementation checks it in sysfs where container is shown as inactive.
>
> Adapt sysfs implementation to work the same way as ioctl.
>
> Signed-off-by: Mariusz Tkaczyk <mariusz.tkaczyk@intel.com>
> ---
> Monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied!
Thanks,
Jes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-16 13:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-16 12:59 [PATCH v2] Monitor: Include containers in spare migration Mariusz Tkaczyk
2017-08-16 13:06 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).