From: NeilBrown <neilb@suse.com>
To: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org, yuyufen <yuyufen@huawei.com>, colyli@suse.de
Subject: [md PATCH 0/2] Resend raid10-NULL-deref fix
Date: Sat, 03 Feb 2018 09:19:30 +1100 [thread overview]
Message-ID: <151760990726.5944.15903931975424856346.stgit@noble> (raw)
Hi Shaohua,
you asked me to resend this (second) patch with improved
comments back in November, and it completely slipped my mind - sorry.
I decided the comments would fit better in a separate patch,
so following are a patch to add comments, and then the bugfix
patch marked for -stable.
You asked:
This will bypass hotadd too, is it what we want?
No, it doesn't. In the only cases where the patch makes a
difference, a non-NULL rdev will have been passed as "this",
so hot-add will be skipped anyway.
This patch includes a bugfix as reported by yuyufen
Thanks,
NeilBrown
---
NeilBrown (2):
md: document lifetime of internal rdev pointer.
md: only allow remove_and_add_spares when no sync_thread running.
drivers/md/md.c | 4 ++++
drivers/md/raid1.h | 12 ++++++++++++
drivers/md/raid10.h | 13 +++++++++++++
drivers/md/raid5.c | 4 ++--
drivers/md/raid5.h | 12 ++++++++++++
5 files changed, 43 insertions(+), 2 deletions(-)
--
Signature
next reply other threads:[~2018-02-02 22:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 22:19 NeilBrown [this message]
2018-02-02 22:19 ` [md PATCH 1/2] md: document lifetime of internal rdev pointer NeilBrown
2018-02-02 22:19 ` [md PATCH 2/2] md: only allow remove_and_add_spares when no sync_thread running NeilBrown
2018-02-06 14:50 ` Artur Paszkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=151760990726.5944.15903931975424856346.stgit@noble \
--to=neilb@suse.com \
--cc=colyli@suse.de \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox