From: Neil Brown <neilb@cse.unsw.edu.au>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: linux-raid@vger.kernel.org
Subject: PATCH - md in 2.4.19-pre - Correctly abort recovery if raid personality indicates an error
Date: Wed, 15 May 2002 15:42:53 +1000 (EST) [thread overview]
Message-ID: <15585.62814.687.214906@notabene.cse.unsw.edu.au> (raw)
When a raid personality reports an error we should make sure
that recovery is aborted.
Normally it would be anyway, as an IO error will cause
md_error to be called which aborts recovery.
However, in raid5, if two drives fail before recovery starts, then no
error will actually happen during recovery, but the raid5 module
will report each resync request as failing. We really shouldn't
ignore this...
----------- Diffstat output ------------
./drivers/md/md.c | 4 ++++
1 files changed, 4 insertions(+)
--- ./drivers/md/md.c 2002/05/15 05:36:13 1.1
+++ ./drivers/md/md.c 2002/05/15 05:38:05 1.2
@@ -3332,6 +3332,10 @@
wake_up(&mddev->recovery_wait);
if (!ok) {
// stop recovery, signal do_sync ....
+ if (mddev->pers->stop_resync)
+ mddev->pers->stop_resync(mddev);
+ if (mddev->recovery_running)
+ md_interrupt_thread(md_recovery_thread);
}
}
reply other threads:[~2002-05-15 5:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15585.62814.687.214906@notabene.cse.unsw.edu.au \
--to=neilb@cse.unsw.edu.au \
--cc=linux-raid@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).