From: Neil Brown <neilb@cse.unsw.edu.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-raid@vger.kernel.org
Subject: PATCH - md 2 of 3 - Md sync: Remove compiler warning that revealed a bug.
Date: Thu, 20 Jun 2002 10:05:23 +1000 (EST) [thread overview]
Message-ID: <15633.7235.452348.379978@notabene.cse.unsw.edu.au> (raw)
When we abort a resync before we even started (because we were
interrupted while waiting for a conflicting resync to finish)
we should not wait or, particularly, do the closing sync_request
(as we haven't even calculated max_sectors yet).
----------- Diffstat output ------------
./drivers/md/md.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
--- ./drivers/md/md.c 2002/06/19 23:20:56 1.2
+++ ./drivers/md/md.c 2002/06/19 23:29:01 1.3
@@ -3230,7 +3230,7 @@
flush_curr_signals();
err = -EINTR;
mddev_put(mddev2);
- goto out;
+ goto skip;
}
}
}
@@ -3331,11 +3331,11 @@
/*
* this also signals 'finished resyncing' to md_stop
*/
-out:
+ out:
wait_event(mddev->recovery_wait, !atomic_read(&mddev->recovery_active));
/* tell personality that we are finished */
mddev->pers->sync_request(mddev, max_sectors, 1);
-
+ skip:
mddev->curr_resync = 0;
if (err)
mddev->recovery_running = err;
reply other threads:[~2002-06-20 0:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15633.7235.452348.379978@notabene.cse.unsw.edu.au \
--to=neilb@cse.unsw.edu.au \
--cc=linux-raid@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).