linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* PATCH - md 2 of 3 - Md sync: Remove compiler warning that revealed a bug.
@ 2002-06-20  0:05 Neil Brown
  0 siblings, 0 replies; only message in thread
From: Neil Brown @ 2002-06-20  0:05 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-raid



When we abort a resync before we even started (because we were
interrupted while waiting for a conflicting resync to finish)
we should not wait or, particularly, do the closing sync_request
(as we haven't even calculated max_sectors yet).


 ----------- Diffstat output ------------
 ./drivers/md/md.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

--- ./drivers/md/md.c	2002/06/19 23:20:56	1.2
+++ ./drivers/md/md.c	2002/06/19 23:29:01	1.3
@@ -3230,7 +3230,7 @@
 					flush_curr_signals();
 					err = -EINTR;
 					mddev_put(mddev2);
-					goto out;
+					goto skip;
 				}
 			}
 		}
@@ -3331,11 +3331,11 @@
 	/*
 	 * this also signals 'finished resyncing' to md_stop
 	 */
-out:
+ out:
 	wait_event(mddev->recovery_wait, !atomic_read(&mddev->recovery_active));
 	/* tell personality that we are finished */
 	mddev->pers->sync_request(mddev, max_sectors, 1);
-
+ skip:
 	mddev->curr_resync = 0;
 	if (err)
 		mddev->recovery_running = err;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-06-20  0:05 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-06-20  0:05 PATCH - md 2 of 3 - Md sync: Remove compiler warning that revealed a bug Neil Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).