* [PATCH mdadm 1/1] Specify nodes number when updating cluster nodes
@ 2020-07-22 5:55 Xiao Ni
0 siblings, 0 replies; only message in thread
From: Xiao Ni @ 2020-07-22 5:55 UTC (permalink / raw)
To: linux-raid, jes; +Cc: ncroxon, heinzm
Now it allow updating cluster nodes without specify --nodes. It can write superblock
with zero nodes. It can break the current cluster. Add this check to avoid this problem.
Signed-off-by: Xiao Ni <xni@redhat.com>
---
mdadm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mdadm.c b/mdadm.c
index 51e16f3..884dc48 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1341,6 +1341,11 @@ int main(int argc, char *argv[])
}
}
+ if (strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
+ pr_err("Please specify nodes number with --nodes\n");
+ exit(1);
+ }
+
if (c.backup_file && data_offset != INVALID_SECTORS) {
pr_err("--backup-file and --data-offset are incompatible\n");
exit(2);
--
2.7.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-22 5:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-22 5:55 [PATCH mdadm 1/1] Specify nodes number when updating cluster nodes Xiao Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).