* [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes
@ 2020-07-23 11:20 Xiao Ni
2020-07-26 9:05 ` Wols Lists
0 siblings, 1 reply; 3+ messages in thread
From: Xiao Ni @ 2020-07-23 11:20 UTC (permalink / raw)
To: linux-raid, jes; +Cc: ncroxon, heinzm
Now it allow updating cluster nodes without specify --nodes. It can write superblock
with zero nodes. It can break the current cluster. Add this check to avoid this problem.
v2: It needs check c.update first to void NULL pointer reference
Signed-off-by: Xiao Ni <xni@redhat.com>
---
mdadm.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/mdadm.c b/mdadm.c
index 51e16f3..e6f0e0b 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -1341,6 +1341,11 @@ int main(int argc, char *argv[])
}
}
+ if (c.update && strcmp(c.update, "nodes") == 0 && c.nodes == 0) {
+ pr_err("Please specify nodes number with --nodes\n");
+ exit(1);
+ }
+
if (c.backup_file && data_offset != INVALID_SECTORS) {
pr_err("--backup-file and --data-offset are incompatible\n");
exit(2);
--
2.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes
2020-07-23 11:20 [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes Xiao Ni
@ 2020-07-26 9:05 ` Wols Lists
2020-07-26 13:44 ` Xiao Ni
0 siblings, 1 reply; 3+ messages in thread
From: Wols Lists @ 2020-07-26 9:05 UTC (permalink / raw)
To: Xiao Ni, linux-raid, jes; +Cc: ncroxon, heinzm
On 23/07/20 12:20, Xiao Ni wrote:
> Now it allow updating cluster nodes without specify --nodes. It can write superblock
> with zero nodes. It can break the current cluster. Add this check to avoid this problem.
>
> v2: It needs check c.update first to void NULL pointer reference
^^^^
Do you mean "avoid"?
>
> Signed-off-by: Xiao Ni <xni@redhat.com>
> ---
Cheers,
Wol
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes
2020-07-26 9:05 ` Wols Lists
@ 2020-07-26 13:44 ` Xiao Ni
0 siblings, 0 replies; 3+ messages in thread
From: Xiao Ni @ 2020-07-26 13:44 UTC (permalink / raw)
To: Wols Lists, linux-raid, jes; +Cc: ncroxon, heinzm
On 07/26/2020 05:05 PM, Wols Lists wrote:
> On 23/07/20 12:20, Xiao Ni wrote:
>> Now it allow updating cluster nodes without specify --nodes. It can write superblock
>> with zero nodes. It can break the current cluster. Add this check to avoid this problem.
>>
>> v2: It needs check c.update first to void NULL pointer reference
> ^^^^
> Do you mean "avoid"?
Hi Wol
Yes. Thanks for pointing out the error. I'll re-send the patch
Regards
Xiao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-26 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-23 11:20 [PATCH v2 mdadm 1/1] Specify nodes number when updating cluster nodes Xiao Ni
2020-07-26 9:05 ` Wols Lists
2020-07-26 13:44 ` Xiao Ni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).